Merge lp:~stolowski/unity-scope-mediascanner/video-sharing into lp:unity-scope-mediascanner

Proposed by Paweł Stołowski
Status: Merged
Approved by: James Henstridge
Approved revision: 322
Merged at revision: 320
Proposed branch: lp:~stolowski/unity-scope-mediascanner/video-sharing
Merge into: lp:unity-scope-mediascanner
Diff against target: 15 lines (+5/-0)
1 file modified
src/myvideos/video-scope.cpp (+5/-0)
To merge this branch: bzr merge lp:~stolowski/unity-scope-mediascanner/video-sharing
Reviewer Review Type Date Requested Status
James Henstridge Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297789@code.launchpad.net

Commit message

Enable sharing via preview for local videos.

Description of the change

Enable sharing via preview for local videos.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

It looks like the code in this branch might have some file name / URI confusion, which could cause problems for file names that contain reserved characters.

review: Needs Information
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/myvideos/video-scope.cpp'
2--- src/myvideos/video-scope.cpp 2016-01-13 05:23:56 +0000
3+++ src/myvideos/video-scope.cpp 2016-06-20 08:21:09 +0000
4@@ -322,6 +322,11 @@
5 video.add_attribute_value("source", Variant(uri));
6 video.add_attribute_mapping("screenshot", "art");
7
8+ VariantMap share_data;
9+ share_data["uri"] = Variant(result().uri());
10+ share_data["content-type"] = Variant("videos");
11+ video.add_attribute_value("share-data", Variant(share_data));
12+
13 PreviewWidget actions("actions", "actions");
14 {
15 VariantBuilder builder;

Subscribers

People subscribed via source and target branches

to all changes: