Merge lp:~stolowski/unity-scope-mediascanner/no-gcc49 into lp:unity-scope-mediascanner

Proposed by Paweł Stołowski
Status: Merged
Approved by: James Henstridge
Approved revision: 256
Merged at revision: 255
Proposed branch: lp:~stolowski/unity-scope-mediascanner/no-gcc49
Merge into: lp:unity-scope-mediascanner
Diff against target: 27 lines (+1/-6)
2 files modified
debian/control (+1/-1)
debian/rules (+0/-5)
To merge this branch: bzr merge lp:~stolowski/unity-scope-mediascanner/no-gcc49
Reviewer Review Type Date Requested Status
James Henstridge Approve
Review via email: mp+264961@code.launchpad.net

Commit message

Drop explicit g++4.9 dependency

Description of the change

Drop explicit g++4.9 dependency

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

You will need to make some extra changes to debian/rules to actually use a non-4.9 compiler. With this change as is, the package will stop building once the default is changed.

review: Needs Fixing
256. By Paweł Stołowski

Remove explicit g++ version from debian/rules

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-04-29 09:52:33 +0000
3+++ debian/control 2015-07-16 08:12:14 +0000
4@@ -4,7 +4,7 @@
5 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
6 Build-Depends: cmake (>= 2.8),
7 # To avoid GCC 4.8/4.9 ABI break issues.
8- g++-4.9,
9+ g++,
10 debhelper (>= 9),
11 google-mock,
12 intltool,
13
14=== modified file 'debian/rules'
15--- debian/rules 2014-06-27 06:52:36 +0000
16+++ debian/rules 2015-07-16 08:12:14 +0000
17@@ -4,10 +4,5 @@
18 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
19 include /usr/share/dpkg/default.mk
20
21-# Explicitly selecting a G{CC,++}-version here to avoid accidental
22-# ABI breaks introduced by toolchain updates.
23-export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
24-export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
25-
26 %:
27 dh $@ --fail-missing --parallel

Subscribers

People subscribed via source and target branches

to all changes: