Merge lp:~stolowski/unity-scope-manpages/compile-regex-once into lp:unity-scope-manpages

[Paweł Stołowski]

Compile regex for apropos output parsing only once

Regex compilation is expensive, so compile regex for apropos results parsing only once.

[lp:~stolowski/unity-scope-manpages/compile-regex-once]

31. By Paweł Stołowski on 2013-05-13

Regex compilation is expensive, so compile regex for apropos results parsing only once.

[David Callé (davidc3)]

+1

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'src/unity_manpages_daemon.py' (properties changed: -x to +x)
--- src/unity_manpages_daemon.py	2013-03-29 23:02:38 +0000
+++ src/unity_manpages_daemon.py	2013-05-13 16:19:23 +0000
@@ -51,7 +51,7 @@
 
 EXTRA_METADATA = []
 
-
+regex_apropos = re.compile('^(.+?)\s+\((\d+)\)\s+-\s(.+?)$')
 def search(search, filters):
     '''
     Use apropos to search for manpages matching the search string
@@ -65,7 +65,6 @@
         out = apropos.communicate()[0]
         out = out.decode('utf8')
         for line in out.split("\n"):
-            regex_apropos = re.compile('^(.+?)\s+\((\d+)\)\s+-\s(.+?)$')
             m = regex_apropos.match(line)
             if m:
                 result.append((m.group(1), m.group(2), m.group(3)))