Merge lp:~stolowski/unity-scope-click/update-preview into lp:unity-scope-click/devel

Proposed by Paweł Stołowski
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 322
Merged at revision: 327
Proposed branch: lp:~stolowski/unity-scope-click/update-preview
Merge into: lp:unity-scope-click/devel
Diff against target: 36 lines (+10/-10)
1 file modified
libclickscope/click/preview.cpp (+10/-10)
To merge this branch: bzr merge lp:~stolowski/unity-scope-click/update-preview
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226420@code.launchpad.net

Commit message

Update preview for current designs (screenshots first, then the icon/header & buttons).

Description of the change

Update preview for current designs (screenshots first, then the icon/header & buttons).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libclickscope/click/preview.cpp'
2--- libclickscope/click/preview.cpp 2014-06-23 15:00:28 +0000
3+++ libclickscope/click/preview.cpp 2014-07-11 08:53:37 +0000
4@@ -205,16 +205,6 @@
5
6 bool has_screenshots = !details.main_screenshot_url.empty() || !details.more_screenshots_urls.empty();
7
8- scopes::PreviewWidget header("hdr", "header");
9- header.add_attribute_value("title", scopes::Variant(details.package.title));
10- if (!details.publisher.empty())
11- {
12- header.add_attribute_value("subtitle", scopes::Variant(details.publisher));
13- }
14- if (!details.package.icon_url.empty())
15- header.add_attribute_value("mascot", scopes::Variant(details.package.icon_url));
16- widgets.push_back(header);
17-
18 if (has_screenshots)
19 {
20 scopes::PreviewWidget gallery("screenshots", "gallery");
21@@ -234,6 +224,16 @@
22 widgets.push_back(gallery);
23 }
24
25+ scopes::PreviewWidget header("hdr", "header");
26+ header.add_attribute_value("title", scopes::Variant(details.package.title));
27+ if (!details.publisher.empty())
28+ {
29+ header.add_attribute_value("subtitle", scopes::Variant(details.publisher));
30+ }
31+ if (!details.package.icon_url.empty())
32+ header.add_attribute_value("mascot", scopes::Variant(details.package.icon_url));
33+ widgets.push_back(header);
34+
35 return widgets;
36 }
37

Subscribers

People subscribed via source and target branches

to all changes: