Merge lp:~stolowski/unity-lens-video/unity-lens-video.previews into lp:unity-lens-video
Proposed by
Paweł Stołowski
Status: | Merged |
---|---|
Approved by: | Michal Hruby |
Approved revision: | 95 |
Merged at revision: | 85 |
Proposed branch: | lp:~stolowski/unity-lens-video/unity-lens-video.previews |
Merge into: | lp:unity-lens-video |
Diff against target: |
108 lines (+63/-1) 1 file modified
src/unity-lens-video (+63/-1) |
To merge this branch: | bzr merge lp:~stolowski/unity-lens-video/unity-lens-video.previews |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Unity Videos lens | Pending | ||
Review via email: mp+118720@code.launchpad.net |
Commit message
Implementation of previews.
Description of the change
Initial implementation of previews.
To post a comment you must log in.
51 + while iter != end_iter: value(iter, 0) == uri:
52 + if model.get_
Linear iteration of the model :/ Not too nice, but hopefully it shouldn't be too much of an issue. s/get_value/ get_string/
72 + preview. add_info( Unity.InfoHint. new("dimensions ", "Dimensions", None, dimensions))
Please use gettext for the user-visible strings.
GLib.format_ size(os. path.getsize( uri[7:] ))))
Uris escape some characters, so they don't map exactly to path, this should be fixed.
87 + return Unity.Activatio nResponse( goto_uri= uri, handled=2 )
Just because this is python doesn't make it ok to use numeric values for enums :) Anyway, you don't really need to connect to the activated signal here, the activation response will by default return NOT_HANDLED, so unity will run the default handler for the file.