Unity Videos Lens

Merge lp:~stolowski/unity-lens-video/fix-scope-ids into lp:~unity-team/unity-lens-video/libunity7-compatible

  1. fix-scope-ids
  2. Merge into libunity7-compatible
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 126
Merged at revision: 124
Proposed branch: lp:~stolowski/unity-lens-video/fix-scope-ids
Merge into: lp:~unity-team/unity-lens-video/libunity7-compatible
Diff against target: 68 lines (+9/-9)
5 files modified
configure.ac (+2/-2)
data/Makefile.am (+3/-3)
debian/unity-lens-video.install (+1/-1)
debian/unity-scope-video-remote.install (+1/-1)
po/POTFILES.in (+2/-2)
To merge this branch: bzr merge lp:~stolowski/unity-lens-video/fix-scope-ids
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+160180@code.launchpad.net

Commit message

Fixed scope ids.

Description of the change

Fixed scope ids.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

Missing configure.ac changes.

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

And maybe it'll be better to s/remote/ubuntuone/?

lp:~stolowski/unity-lens-video/fix-scope-ids updated
125. By Paweł Stołowski

Updated configure.ac and debian/*install files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:125
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/4/rebuild

review: Needs Fixing (continuous-integration)
lp:~stolowski/unity-lens-video/fix-scope-ids updated
126. By Paweł Stołowski

Update POTFILES.in.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:126
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/5

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/5/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-03-13 15:55:38 +0000
3+++ configure.ac 2013-04-23 08:49:29 +0000
4@@ -174,8 +174,8 @@
5 AC_CONFIG_FILES([
6 Makefile
7 data/Makefile
8- data/video-local.scope.in
9- data/video-remote.scope.in
10+ data/local.scope.in
11+ data/remote.scope.in
12 src/Makefile
13 po/Makefile.in
14 src/config.vala
15
16=== modified file 'data/Makefile.am'
17--- data/Makefile.am 2013-03-14 18:44:52 +0000
18+++ data/Makefile.am 2013-04-23 08:49:29 +0000
19@@ -9,7 +9,7 @@
20 %.service: %.service.in
21 $(AM_V_GEN)sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
22
23-scope_in_files = video-local.scope.in video-remote.scope.in
24+scope_in_files = local.scope.in remote.scope.in
25 scopedir = $(SCOPESDIR)/video
26 scope_DATA = $(scope_in_files:.scope.in=.scope)
27
28@@ -23,6 +23,6 @@
29 CLEANFILES = \
30 unity-scope-video-remote.service \
31 unity-lens-video.service \
32- video-local.scope \
33- video-remote.scope \
34+ local.scope \
35+ remote.scope \
36 $(NULL)
37
38=== renamed file 'data/video-local.scope.in.in' => 'data/local.scope.in.in'
39=== renamed file 'data/video-remote.scope.in.in' => 'data/remote.scope.in.in'
40=== modified file 'debian/unity-lens-video.install'
41--- debian/unity-lens-video.install 2013-03-15 13:16:17 +0000
42+++ debian/unity-lens-video.install 2013-04-23 08:49:29 +0000
43@@ -1,3 +1,3 @@
44 /usr/lib/*/unity-lens-video/unity-video-lens-daemon
45 /usr/share/dbus-1/services/unity-scope-video-local.service
46-/usr/share/unity/scopes/video/video-local.scope
47+/usr/share/unity/scopes/video/local.scope
48
49=== modified file 'debian/unity-scope-video-remote.install'
50--- debian/unity-scope-video-remote.install 2013-03-15 13:16:17 +0000
51+++ debian/unity-scope-video-remote.install 2013-04-23 08:49:29 +0000
52@@ -1,3 +1,3 @@
53 /usr/lib/*/unity-lens-video/unity-scope-video-remote
54 /usr/share/dbus-1/services/unity-scope-video-remote.service
55-/usr/share/unity/scopes/video/video-remote.scope
56+/usr/share/unity/scopes/video/remote.scope
57
58=== modified file 'po/POTFILES.in'
59--- po/POTFILES.in 2013-03-13 15:55:38 +0000
60+++ po/POTFILES.in 2013-04-23 08:49:29 +0000
61@@ -3,5 +3,5 @@
62 src/remote-video-main.vala
63 src/ubuntu-video-search.vala
64 tests/unit/test-ubuntu-video-search.vala
65-[type: gettext/ini]data/video-local.scope.in
66-[type: gettext/ini]data/video-remote.scope.in
67+[type: gettext/ini]data/local.scope.in
68+[type: gettext/ini]data/remote.scope.in

Subscribers

People subscribed via source and target branches