unity-lens-applications

Merge lp:~stolowski/unity-lens-applications/normalize-ratings into lp:unity-lens-applications

  1. normalize-ratings
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 295
Merged at revision: 295
Proposed branch: lp:~stolowski/unity-lens-applications/normalize-ratings
Merge into: lp:unity-lens-applications
Diff against target: 12 lines (+1/-1)
1 file modified
src/daemon.vala (+1/-1)
To merge this branch: bzr merge lp:~stolowski/unity-lens-applications/normalize-ratings
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+122894@code.launchpad.net

Commit message

Average application rating in the preview should be divided by 5, i.e. in range 0.0 - 1.0.

Description of the change

Average application rating in the preview should be divided by 5, i.e. in range 0.0 - 1.0.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/daemon.vala'
2--- src/daemon.vala 2012-08-30 11:23:14 +0000
3+++ src/daemon.vala 2012-09-05 15:00:25 +0000
4@@ -1211,7 +1211,7 @@
5 {
6 Unity.Ratings.Result result;
7 ratings.query (pkgname, out result);
8- preview.set_rating (result.average_rating, result.total_rating);
9+ preview.set_rating (result.average_rating / 5.0f, result.total_rating);
10 }
11
12 if (sc_data_provider.hardware_requirements != "")

Subscribers

People subscribed via source and target branches