Merge lp:~stolowski/unity-api/social-attributes-role into lp:unity-api

Proposed by Paweł Stołowski
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 218
Merged at revision: 227
Proposed branch: lp:~stolowski/unity-api/social-attributes-role
Merge into: lp:unity-api
Prerequisite: lp:~stolowski/unity-api/value-slider-iface
Diff against target: 72 lines (+13/-2)
5 files modified
debian/changelog (+6/-0)
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ResultsModelInterface.h (+3/-1)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockResultsModel.cpp (+2/-0)
test/qmltest/unity/shell/scopes/tst_Scopes.qml (+1/-0)
To merge this branch: bzr merge lp:~stolowski/unity-api/social-attributes-role
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
Unity8 CI Bot continuous-integration Needs Fixing
Andrea Cimitan Pending
Review via email: mp+289165@code.launchpad.net

This proposal supersedes a proposal from 2016-03-02.

Commit message

Added RoleSocialActions.

Description of the change

Added RoleSocialActions.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
218. By Paweł Stołowski

Merged trunk + bump

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:217
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/46/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1133
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1121
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1121
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1119/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1119/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1119/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1119/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1119/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1119
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1119/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/46/rebuild

review: Approve (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

+1

review: Approve
219. By Paweł Stołowski

Merged trunk + bump

220. By Paweł Stołowski

Merged trunk

221. By Paweł Stołowski

Fix version

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-04-13 18:39:21 +0000
3+++ debian/changelog 2016-04-26 15:30:33 +0000
4@@ -1,3 +1,9 @@
5+unity-api (7.111) UNRELEASED; urgency=medium
6+
7+ * Added RoleSocialActions to ResultsModelInterface of scopes.
8+
9+ -- Pawel Stolowski <pawel.stolowski@canonical.com> Thu, 25 Apr 2016 10:00:42 +0100
10+
11 unity-api (7.110+16.04.20160413-0ubuntu1) xenial; urgency=medium
12
13 [ Daniel d'Andrada ]
14
15=== modified file 'include/unity/shell/scopes/CMakeLists.txt'
16--- include/unity/shell/scopes/CMakeLists.txt 2016-03-07 08:27:45 +0000
17+++ include/unity/shell/scopes/CMakeLists.txt 2016-04-26 15:30:33 +0000
18@@ -7,7 +7,7 @@
19
20 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
21
22-set(VERSION 11)
23+set(VERSION 12)
24 set(PKGCONFIG_NAME "unity-shell-scopes")
25 set(PKGCONFIG_DESCRIPTION "Unity shell Scopes APIs")
26 set(PKGCONFIG_REQUIRES "Qt5Core")
27
28=== modified file 'include/unity/shell/scopes/ResultsModelInterface.h'
29--- include/unity/shell/scopes/ResultsModelInterface.h 2015-09-16 10:05:47 +0000
30+++ include/unity/shell/scopes/ResultsModelInterface.h 2016-04-26 15:30:33 +0000
31@@ -71,7 +71,8 @@
32 RoleAttributes,
33 RoleBackground,
34 RoleOverlayColor,
35- RoleQuickPreviewData ///< Data for UI quick previewing. In case of audio should contain uri and duration
36+ RoleQuickPreviewData, ///< Data for UI quick previewing. In case of audio should contain uri and duration
37+ RoleSocialActions ///< Data for social actions (in-card actions such as "+1").
38 };
39
40 // @cond
41@@ -96,6 +97,7 @@
42 roles[RoleAttributes] = "attributes";
43 roles[RoleBackground] = "background";
44 roles[RoleOverlayColor] = "overlayColor";
45+ roles[RoleSocialActions] = "socialActions";
46 return roles;
47 }
48
49
50=== modified file 'test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockResultsModel.cpp'
51--- test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockResultsModel.cpp 2014-07-18 12:56:46 +0000
52+++ test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockResultsModel.cpp 2016-04-26 15:30:33 +0000
53@@ -67,6 +67,8 @@
54 case RoleUri:
55 case RoleCategoryId:
56 case RoleDndUri:
57+ case RoleAttributes:
58+ case RoleSocialActions:
59 default:
60 return QString();
61 }
62
63=== modified file 'test/qmltest/unity/shell/scopes/tst_Scopes.qml'
64--- test/qmltest/unity/shell/scopes/tst_Scopes.qml 2016-03-07 08:27:25 +0000
65+++ test/qmltest/unity/shell/scopes/tst_Scopes.qml 2016-04-26 15:30:33 +0000
66@@ -427,6 +427,7 @@
67 { tag: "Model.roles[attributes]", role: "attributes", type: "string" },
68 { tag: "Model.roles[background]", role: "background", type: "object" },
69 { tag: "Model.roles[overlayColor]", role: "overlayColor", type: "string" },
70+ { tag: "Model.roles[socialActions]", role: "socialActions", type: "string" },
71 ];
72 }
73

Subscribers

People subscribed via source and target branches

to all changes: