Merge lp:~stolowski/unity-api/activation-progress into lp:unity-api

Proposed by Paweł Stołowski on 2016-01-29
Status: Merged
Approved by: Albert Astals Cid on 2016-02-03
Approved revision: 207
Merged at revision: 211
Proposed branch: lp:~stolowski/unity-api/activation-progress
Merge into: lp:unity-api
Diff against target: 71 lines (+13/-1)
4 files modified
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ScopeInterface.h (+7/-0)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp (+4/-0)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h (+1/-0)
To merge this branch: bzr merge lp:~stolowski/unity-api/activation-progress
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) 2016-01-29 Approve on 2016-02-03
PS Jenkins bot continuous-integration Approve on 2016-01-29
Unity8 CI Bot continuous-integration Approve on 2016-01-29
Review via email: mp+284424@code.launchpad.net

Commit Message

Interface for activationInProgress flag.

Description of the Change

Interface for activationInProgress flag.

To post a comment you must log in.
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:207
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-1-ci/9/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-1-ci/9/rebuild

review: Approve (continuous-integration)
Albert Astals Cid (aacid) wrote :

Looks good

review: Approve
208. By Paweł Stołowski on 2016-02-03

Don't bump changelog

209. By Paweł Stołowski on 2016-02-22

Merged trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/unity/shell/scopes/CMakeLists.txt'
2--- include/unity/shell/scopes/CMakeLists.txt 2015-11-30 09:18:57 +0000
3+++ include/unity/shell/scopes/CMakeLists.txt 2016-02-22 11:54:09 +0000
4@@ -7,7 +7,7 @@
5
6 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
7
8-set(VERSION 9)
9+set(VERSION 10)
10 set(PKGCONFIG_NAME "unity-shell-scopes")
11 set(PKGCONFIG_DESCRIPTION "Unity shell Scopes APIs")
12 set(PKGCONFIG_REQUIRES "Qt5Core")
13
14=== modified file 'include/unity/shell/scopes/ScopeInterface.h'
15--- include/unity/shell/scopes/ScopeInterface.h 2015-10-05 12:54:22 +0000
16+++ include/unity/shell/scopes/ScopeInterface.h 2016-02-22 11:54:09 +0000
17@@ -74,6 +74,11 @@
18 Q_PROPERTY(bool searchInProgress READ searchInProgress NOTIFY searchInProgressChanged)
19
20 /**
21+ * @brief Boolean specifying whether an activation request is currently running.
22+ */
23+ Q_PROPERTY(bool activationInProgress READ activationInProgress NOTIFY activationInProgressChanged)
24+
25+ /**
26 * @brief Boolean specifying whether the scope is favourited.
27 */
28 Q_PROPERTY(bool favorite READ favorite WRITE setFavorite NOTIFY favoriteChanged)
29@@ -173,6 +178,7 @@
30 virtual QString searchHint() const = 0;
31 virtual QString shortcut() const = 0;
32 virtual bool searchInProgress() const = 0;
33+ virtual bool activationInProgress() const = 0;
34 virtual bool favorite() const = 0;
35 virtual CategoriesInterface* categories() const = 0;
36 virtual SettingsModelInterface* settings() const = 0;
37@@ -256,6 +262,7 @@
38 void descriptionChanged();
39 void searchHintChanged();
40 void searchInProgressChanged();
41+ void activationInProgressChanged();
42 void favoriteChanged();
43 void shortcutChanged();
44 void categoriesChanged();
45
46=== modified file 'test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp'
47--- test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp 2015-10-05 12:54:22 +0000
48+++ test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp 2016-02-22 11:54:09 +0000
49@@ -77,6 +77,10 @@
50 return m_searching;
51 }
52
53+bool MockScope::activationInProgress() const {
54+ return false;
55+}
56+
57 unity::shell::scopes::CategoriesInterface* MockScope::categories() const {
58 return m_categories;
59 }
60
61=== modified file 'test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h'
62--- test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h 2015-10-05 12:54:22 +0000
63+++ test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h 2016-02-22 11:54:09 +0000
64@@ -36,6 +36,7 @@
65 bool favorite() const override;
66 QString shortcut() const override;
67 bool searchInProgress() const override;
68+ bool activationInProgress() const override;
69 unity::shell::scopes::CategoriesInterface* categories() const override;
70 unity::shell::scopes::SettingsModelInterface* settings() const override;
71 QString searchQuery() const override;

Subscribers

People subscribed via source and target branches

to all changes: