Merge lp:~stolowski/unity-2d/hud-a11-focus-fixes into lp:unity-2d

[Paweł Stołowski]

[hud] Force active focus on Search entry whenever a key is pressed. Force active focus on results list on Up/Down keys.

[hud] Force active focus on Search entry whenever a key is pressed. Force active focus on results list on Up/Down keys.
UNBLOCK

[Albert Astals Cid (aacid)]

We loose the blinking cursor on the text entry by doing this. Can you investigate how to fix it?

review: Needs Fixing

[Albert Astals Cid (aacid)]

The blinking cursor is lost after i press down arrow, sorry for the incomplete information

[lp:~stolowski/unity-2d/hud-a11-focus-fixes]

1071. By Paweł Stołowski on 2012-04-19

Added forceCursorVisible property to SearchEntry to make it possible to
force cursor visibility in Hud even if text entry doesn't have focus (i.e.
results list has focus).

1072. By Paweł Stołowski on 2012-04-19

Added forceTextInputFocus function to force search entry focus from Hud, instead of
forcing in unconditional in SearchEntry code.

[Albert Astals Cid (aacid)]

There is still the problem, after i first type something in the hud, the first entry in the result list gets selected, but it's not spoken out loud by orca

review: Needs Fixing

[lp:~stolowski/unity-2d/hud-a11-focus-fixes]

1073. By Paweł Stołowski on 2012-04-19

Force focus on resultList in onCurrentChanged signal handler - makes Orca read
the 1st result item. Call forceTextInputFocus from SearchEntry.

1074. By Paweł Stołowski on 2012-04-19

Added anyKeypressGivesFocus property (defaults to false) to SearchEntry, it is enabled for Hud.

[Albert Astals Cid (aacid)]

Approved! the focus hopping is a bit hacky but works well and can't think of something better

review: Approve

[Albert Astals Cid (aacid)]

Actually, can you please add a manual test?

[Albert Astals Cid (aacid)]

review: Needs Fixing

[lp:~stolowski/unity-2d/hud-a11-focus-fixes]

1075. By Paweł Stołowski on 2012-04-19

Updated hud test case.

[Albert Astals Cid (aacid)]

Good stuff :)

review: Approve

=== modified file 'shell/common/SearchEntry.qml'
--- shell/common/SearchEntry.qml	2012-04-02 16:18:24 +0000
+++ shell/common/SearchEntry.qml	2012-04-19 15:06:22 +0000
@@ -26,6 +26,8 @@
     property string searchQuery
     property string placeHolderText: ""
     property bool active: false
+    property alias forceCursorVisible: searchInput.forceCursorVisible
+    property alias anyKeypressGivesFocus: searchInput.anyKeypressGivesFocus
 
     signal activateFirstResult
 
@@ -84,6 +86,8 @@
 
         TextInput {
             id: searchInput
+            property bool forceCursorVisible: false
+            property bool anyKeypressGivesFocus: false
 
             Accessible.name: searchInstructions.text
             Accessible.role: Accessible.EditableText
@@ -110,6 +114,9 @@
             }
 
             Keys.onPressed: {
+                if (anyKeypressGivesFocus) {
+                    forceActiveFocus();
+                }
                 if (event.key == Qt.Key_Return || event.key == Qt.Key_Enter) {
                     activateFirstResult()
                     event.accepted = true;
@@ -135,9 +142,9 @@
                     anchors.topMargin: 2
                     anchors.bottomMargin: 2
                     width: 1
-                    visible: parent.activeFocus && timerShowCursor
+                    visible: (customCursor.parent.forceCursorVisible || parent.activeFocus) && timerShowCursor
                     Timer {
-                        interval: 800; running: customCursor.parent.activeFocus; repeat: true
+                        interval: 800; running: (customCursor.parent.forceCursorVisible || customCursor.parent.activeFocus); repeat: true
                         onTriggered: {
                             interval = interval == 800 ? 400 : 800
                             customCursor.timerShowCursor = !customCursor.timerShowCursor

=== modified file 'shell/hud/Hud.qml'
--- shell/hud/Hud.qml	2012-04-16 15:14:34 +0000
+++ shell/hud/Hud.qml	2012-04-19 15:06:22 +0000
@@ -199,6 +199,8 @@
             SearchEntry {
                 id: searchEntry
                 focus: true
+                forceCursorVisible: true
+                anyKeypressGivesFocus: true
 
                 anchors.top: parent.top
                 anchors.left: parent.left
@@ -251,6 +253,7 @@
                 }
 
                 onCurrentItemChanged: {
+                    resultList.forceActiveFocus();
                     if (currentItem != null && count > 0) {
                         appIcon = "image://icons/" + (currentItem.icon ? currentItem.icon : "unknown")
                     } else {

=== modified file 'tests/manual-tests/hud.txt'
--- tests/manual-tests/hud.txt	2012-04-16 15:14:34 +0000
+++ tests/manual-tests/hud.txt	2012-04-19 15:06:22 +0000
@@ -12,9 +12,11 @@
  * Enable Accessibility and Orca speech output
  * Tap Alt key
  * Enter a few characters
- * Use arrow keys to navigate up/down through the options returned
-
---> Check Orca speaks the contents of the results
+--> Check that Orca speaks the contents of the first highlighted item
+ * Use Up/Down keys to navigate through the options returned and Left/Right to move over search query
+--> Check that Orca speaks the contents of the results as they are browsed with Up/Down
+--> Check that cursor keeps blinking in the search entry.
+--> Check that Orca speaks search query letters as you move the caret Left/Right
 
 ----
  * Go into ccsm