Ubuntu Terminal App

Merge lp:~stolowski/ubuntu-terminal-app/default-department-id-key into lp:ubuntu-terminal-app

  1. default-department-id-key
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: David Planella
Approved revision: 94
Merged at revision: 98
Proposed branch: lp:~stolowski/ubuntu-terminal-app/default-department-id-key
Merge into: lp:ubuntu-terminal-app
Diff against target: 8 lines (+1/-0)
1 file modified
com.ubuntu.terminal.desktop.in (+1/-0)
To merge this branch: bzr merge lp:~stolowski/ubuntu-terminal-app/default-department-id-key
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Needs Information
Review via email: mp+227584@code.launchpad.net

Commit message

Added X-Ubuntu-Default-Department-ID key to the desktop file. This is required by click scope to support departments for preinstalled applications.

Description of the change

Added X-Ubuntu-Default-Department-ID key to the desktop file. This is required by click scope to support departments for preinstalled applications.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Would it not be better under the developer tools department?

review: Needs Information
Revision history for this message
Paweł Stołowski (stolowski) wrote :

> Would it not be better under the developer tools department?

Any change would need to be done in the Ubuntu Store first, and we should just reflect what's in the store. If we add our own department here, then first time user visits the preview of Terminal in the store, it will "get moved" to the department given by store.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.ubuntu.terminal.desktop.in'
2--- com.ubuntu.terminal.desktop.in 2014-05-30 15:27:34 +0000
3+++ com.ubuntu.terminal.desktop.in 2014-07-21 15:22:09 +0000
4@@ -7,3 +7,4 @@
5 Name=Terminal
6 X-Ubuntu-Touch=true
7 X-Ubuntu-Gettext-Domain=@PROJECT_NAME@
8+X-Ubuntu-Default-Department-ID=accessories

Subscribers

People subscribed via source and target branches