dialer-app

Merge lp:~stolowski/dialer-app/default-department-id-key into lp:dialer-app

  1. default-department-id-key
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 188
Merged at revision: 205
Proposed branch: lp:~stolowski/dialer-app/default-department-id-key
Merge into: lp:dialer-app
Diff against target: 9 lines (+1/-0)
1 file modified
src/dialer-app.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp:~stolowski/dialer-app/default-department-id-key
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+227588@code.launchpad.net

Commit message

Added X-Ubuntu-Default-Department-ID key to the desktop file. This is required by click scope to support departments for preinstalled applications.

Description of the change

Added X-Ubuntu-Default-Department-ID key to the desktop file. This is required by click scope to support departments for preinstalled applications.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:188
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/302/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/72
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/72/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2249
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1867
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2452
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3433
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3433/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10147
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1568
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2086
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2086/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/302/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but not related to this MR.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dialer-app.desktop.in.in'
2--- src/dialer-app.desktop.in.in 2014-07-16 20:43:16 +0000
3+++ src/dialer-app.desktop.in.in 2014-07-21 15:24:40 +0000
4@@ -11,4 +11,5 @@
5 X-Ubuntu-Touch=true
6 X-Ubuntu-StageHint=SideStage
7 X-Ubuntu-Single-Instance=true
8+X-Ubuntu-Default-Department-ID=accessories
9 X-Screenshot=@CMAKE_INSTALL_PREFIX@/@DIALER_APP_DIR@/assets/dialer-app-screenshot.png

Subscribers

People subscribed via source and target branches