Merge lp:~stolowski/bamf-qt/fix-bamfview-removal into lp:bamf-qt

Proposed by Paweł Stołowski on 2012-04-13
Status: Merged
Approved by: Albert Astals Cid on 2012-04-16
Approved revision: 395
Merged at revision: 395
Proposed branch: lp:~stolowski/bamf-qt/fix-bamfview-removal
Merge into: lp:bamf-qt
Diff against target: 10 lines (+1/-1)
1 file modified
bamf-factory.cpp (+1/-1)
To merge this branch: bzr merge lp:~stolowski/bamf-qt/fix-bamfview-removal
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) 2012-04-13 Approve on 2012-04-13
Florian Boucault 2012-04-13 Pending
Review via email: mp+101919@code.launchpad.net

Commit message

Don't delete BamfView sender object immediately in BamfFactory::OnViewClosed slot, as there may be more receipients of Closed() signal. This makes it impossible for unity-2d to react on Closed() signal. Use deleteLater() instead.

Description of the change

Don't delete BamfView sender object immediately in BamfFactory::OnViewClosed slot, as there
may be more receipients of Closed() signal. This makes it impossible for unity-2d to react on Closed() signal.
Use deleteLater() instead.

UNBLOCK

To post a comment you must log in.
Albert Astals Cid (aacid) wrote :

Code makes sense and indeed fixes the problem. I'm waiting on global approving since we are on the middle of the release and we better confirm with Gerry what to do with this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bamf-factory.cpp'
2--- bamf-factory.cpp 2011-01-13 21:37:10 +0000
3+++ bamf-factory.cpp 2012-04-13 15:02:22 +0000
4@@ -70,6 +70,6 @@
5 void
6 BamfFactory::OnViewClosed()
7 {
8- delete sender();
9+ sender()->deleteLater();
10 }
11

Subscribers

People subscribed via source and target branches