Merge lp:~stipple-devs/stipple/stipple-empathy into lp:stipple
| Status: | Merged |
|---|---|
| Approved by: | malev on 2010-07-24 |
| Approved revision: | 18 |
| Merged at revision: | 18 |
| Proposed branch: | lp:~stipple-devs/stipple/stipple-empathy |
| Merge into: | lp:stipple |
| Diff against target: |
93 lines (+84/-0) 2 files modified
plugins/empathy-accounts.py (+42/-0) plugins/empathy-logs.py (+42/-0) |
| To merge this branch: | bzr merge lp:~stipple-devs/stipple/stipple-empathy |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Duane Hinnen | Approve on 2010-07-24 | ||
| malev (community) | 2010-07-23 | Approve on 2010-07-24 | |
|
Review via email:
|
|||
Description of the Change
Added 2 separate plugins for empathy. 1 to sync account info, 1 to sync account logs. These 2 functions were originally combined into 1 plugin that didn't work due to a bug in the stipple.py code which is now fixed. Both Duane & I are undecided whether this functionality should be combined into 1 plugin or split into 2 different plugins.
The 'use case' for having 2 separate plugins is a user who wants to sync *only* their account info, not their conversation logs. Please feel free to comment with your thoughts.
| Duane Hinnen (duanedesign) wrote : | # |
Looks good. Will approve it. I think malev and I are starting to lean towards having it in one plugin. We will merge this branch and if we decide to combine them we can do it after the merge.
| Shashank Sahni (shredder12) wrote : | # |
I think providing the user with options is a good idea but splitting a plugin is not. What if we could use some form of nested check buttons for this purpose. Check this http://


I like it