Merge lp:~stgraber/ubuntu/saucy/lxc-android-config/upstart-fixes into lp:ubuntu/saucy/lxc-android-config

Proposed by Stéphane Graber
Status: Merged
Merge reported by: Oliver Grawert
Merged at revision: not available
Proposed branch: lp:~stgraber/ubuntu/saucy/lxc-android-config/upstart-fixes
Merge into: lp:ubuntu/saucy/lxc-android-config
Diff against target: 39 lines (+12/-5)
2 files modified
debian/changelog (+7/-0)
debian/lxc-android-config.upstart (+5/-5)
To merge this branch: bzr merge lp:~stgraber/ubuntu/saucy/lxc-android-config/upstart-fixes
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+187589@code.launchpad.net

Commit message

Fix some upstart issues.

Description of the change

Fix some upstart issues.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Hm, I wish lxc-stop can support "-s -k" clean shutdown, and eventually kill everything. But simply killing also works, as actually android doesn't have any sensible shutdown mechanisms => their shutdown command syncs filesystems and kills everything. I guess I need this changes to get the emulator working properly and/or experiment with starting and stopping the lxc container.

review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

bah, this has already landed via upstream project.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-09-25 17:50:56 +0000
3+++ debian/changelog 2013-09-25 19:44:16 +0000
4@@ -1,3 +1,10 @@
5+lxc-android-config (0.103) UNRELEASED; urgency=low
6+
7+ * Fix some issues with the upstart job so that it gets into the right
8+ state at boot time and properly shuts down.
9+
10+ -- Stéphane Graber <stgraber@ubuntu.com> Wed, 25 Sep 2013 15:42:51 -0400
11+
12 lxc-android-config (0.102) saucy; urgency=low
13
14 [ Sebastien Bacher ]
15
16=== modified file 'debian/lxc-android-config.upstart'
17--- debian/lxc-android-config.upstart 2013-08-27 12:38:24 +0000
18+++ debian/lxc-android-config.upstart 2013-09-25 19:44:16 +0000
19@@ -9,6 +9,10 @@
20
21 emits android
22
23+console none
24+
25+exec lxc-start -n android -- /init
26+
27 post-start script
28 if [ ! -d /dev/cpuctl ] && [ -d /sys/fs/cgroup/cpu ]; then
29 mkdir /dev/cpuctl
30@@ -25,8 +29,4 @@
31 initctl emit android
32 end script
33
34-exec lxc-start -n android -d -- /init
35-
36-pre-stop script
37- exec lxc-stop -n android
38-end script
39+pre-stop exec lxc-stop -n android -k

Subscribers

People subscribed via source and target branches