Merge ~stgraber/simplestreams:master into simplestreams:master

Proposed by Stéphane Graber
Status: Merged
Approved by: Paride Legovini
Approved revision: d5dfebc5e9062d7ef98027b32d36ecfdb809d4fa
Merged at revision: d5dfebc5e9062d7ef98027b32d36ecfdb809d4fa
Proposed branch: ~stgraber/simplestreams:master
Merge into: simplestreams:master
Diff against target: 28 lines (+0/-10)
1 file modified
tools/make-test-data (+0/-10)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
Paride Legovini Approve
Review via email: mp+391480@code.launchpad.net

Commit message

Re-enable disk-kvm images (used on focal/groovy).

The kernel has now been updated to boot properly on LXD.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paride Legovini (paride) wrote :

LGTM!

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/simplestreams-autoland-test/60/
Executed test runs:
    None: https://jenkins.ubuntu.com/server/job/admin-lp-git-autoland/1020/

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/make-test-data b/tools/make-test-data
2index 3e0d52c..a287dab 100755
3--- a/tools/make-test-data
4+++ b/tools/make-test-data
5@@ -312,11 +312,6 @@ def create_fake_file(prefix, item):
6 ('disk-kvm-img', '-disk-kvm.img'),
7 ('rootxz', '-root.tar.xz'),
8 ('squashfs', '.squashfs')):
9-
10- # disk-kvm-img isn't currently bootable under LXD. LP: #1873809
11- if name == "disk-kvm-img":
12- continue
13-
14 if (ftype == "lxd.tar.xz" and
15 'combined_{}_sha256'.format(name) not in FAKE_DATA[ftype]):
16 rootpath = item['path'].replace("-lxd.tar.xz", extension)
17@@ -591,11 +586,6 @@ def create_image_data(query_tree, out_d, streamdir):
18 ('disk-kvm-img', '-disk-kvm.img'),
19 ('rootxz', '-root.tar.xz'),
20 ('squashfs', '.squashfs')):
21-
22- # disk-kvm-img isn't currently bootable under LXD. LP: #1873809
23- if name == "disk-kvm-img":
24- continue
25-
26 root = lxd.replace('-lxd.tar.xz', extension)
27 combined = os.path.join(dirname, ','.join([lxd, root]))
28 value = get_cache_data(combined, 'sha256')

Subscribers

People subscribed via source and target branches