Merge lp:~stewart/percona-xtrabackup/test-more-parallel into lp:percona-xtrabackup/2.1

Proposed by Stewart Smith
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 614
Proposed branch: lp:~stewart/percona-xtrabackup/test-more-parallel
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 12 lines (+1/-1)
1 file modified
test/testrun.c (+1/-1)
To merge this branch: bzr merge lp:~stewart/percona-xtrabackup/test-more-parallel
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
George Ormond Lorch III (community) g2 Approve
Review via email: mp+169334@code.launchpad.net

Description of the change

This simple change back to using NRCPUS workers instead of NRCPUS/2 seems to knock at least 10minutes off XB build+test time.

old (25min):
http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/BUILD_TYPE=release,Host=debian6-64,xtrabackuptarget=innodb51/328/
with this patch (15min):
http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/332/BUILD_TYPE=release,Host=debian6-64,xtrabackuptarget=innodb51/

Since we appear to have fixed any interference between tests running simultaneously, everything appears to work okay too.

Jenkins run for this branch: http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/332/

To post a comment you must log in.
Revision history for this message
George Ormond Lorch III (gl-az) wrote :

As per IRC discussion, no 2.0 change...

review: Approve (g2)
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/testrun.c'
2--- test/testrun.c 2013-01-11 13:00:50 +0000
3+++ test/testrun.c 2013-06-14 03:58:26 +0000
4@@ -353,7 +353,7 @@
5 sigaction(SIGQUIT, &sa, NULL);
6
7 #ifdef _SC_NPROCESSORS_ONLN
8- njobs= sysconf(_SC_NPROCESSORS_ONLN) /2;
9+ njobs= sysconf(_SC_NPROCESSORS_ONLN);
10 #endif
11
12 #ifdef _SC_PHYS_PAGES

Subscribers

People subscribed via source and target branches