Code review comment for lp:~stewart/percona-xtrabackup/source-dist-refactor

Ignacio Nin <email address hidden> writes:
> Review: Needs Fixing optionalenhancements
>
> make dist works perfectly, but a couple of comments in build-*.sh:
>
> build-rpm.sh: shebang added -x, not sure why -- perhaps a debugging
> step?

Yep, for debugging... I can't remember what I hit at some point, but it
helped in working things out.

> - $SOURCEDIR/../percona-xtrabackup-$XTRABACKUP_VERSION*.tar.gz is
> hardcoded as the source, making the script unnecesarily fail in
> current cases (including the most common case). We can solve this by
> instead changing the bzr export for a cp -a, and we'd keep the script
> functional in the current cases.

That could indeed work, although isn't current jobs having workdir as
subdir of sourcedir, which wouldn't work with cp -a.

> build-dpkg: Unnecesarily stripping the ability to build in any
> directory (WORKDIR, SOURCEDIR). Again we can keep this functionality
> and add the new changes by substituting the bzr export for a cp -a,
> and the change would be even smaller.

we'd need to point build-dpkg at the source tarball anyway.. so I'm not
too sure of the benefit (you have to build the source tarball before you
can build debs)

> I can rework to include these changes if wanted, else if you feel they
> aren't needed you can go ahead with the merge.

I'd be interested to see the patch, but I don't think it's urgent for
getting out some source tarballs that we can use for debian.

--
Stewart Smith