Code review comment for lp:~stewart/percona-server/pkg-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

http://jenkins.percona.com/job/percona-server-5.5-param/929/:

mysql_plugin:

--- /home/jenkins/workspace/percona-server-5.5-param/BUILD_TYPE/release/Host/ubuntu-saucy-64bit/mysql-test/r/mysql_plugin.result 2014-01-10 16:19:54.723958000 +0300
+++ /home/jenkins/workspace/percona-server-5.5-param/BUILD_TYPE/release/Host/ubuntu-saucy-64bit/mysql-test/r/mysql_plugin.reject 2014-01-10 16:30:03.798644967 +0300
@@ -101,7 +101,7 @@
 #
 # Show the help.
 #
-mysql_plugin Ver V.V.VV Distrib XX.XX.XX
+mysql_plugin Ver V.V.VV Distrib XX.XX.XX-32.0
 Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.

 Enable or disable plugins.
@@ -129,4 +129,4 @@
   -V, --version Output version information and exit.

-mysql_plugin Ver V.V.VV Distrib XX.XX.XX
+mysql_plugin Ver V.V.VV Distrib XX.XX.XX-32.0

mysqltest: Result content mismatch

file_contents:

--- /home/jenkins/workspace/percona-server-5.5-param/BUILD_TYPE/release/Host/ubuntu-saucy-64bit/mysql-test/r/file_contents.result 2014-01-10 16:19:54.723958000 +0300
+++ /home/jenkins/workspace/percona-server-5.5-param/BUILD_TYPE/release/Host/ubuntu-saucy-64bit/mysql-test/r/file_contents.reject 2014-01-10 16:30:27.364111797 +0300
@@ -1,6 +1,6 @@

 Checking 'INFO_SRC' and 'INFO_BIN'
-INFO_SRC: Found MySQL version number / Found BZR revision id
+INFO_SRC: Found MySQL version number / No line 'revision-id: .....'
 INFO_BIN: Found 'Compiler ... used' line / Found 'Feature flags' line

review: Needs Fixing

« Back to merge proposal