Code review comment for lp:~stewart/percona-server/bug1012488

Alexey Kopytov (akopytov) wrote :

Sigh, kewpie again. Thanks to wonderful the idea of merging kewpie to every individual project, we now have a bunch of sysbench-related code, randgen-related code, xtrabackup-related code in plugin/percona-pam-for-mysql/test.

All of that is because of 2 rudementary tests pam_negative_test.py and pam_basic_test.py. There's absolutely no reason to base them on kewpie. Apparently there was also an attempt to use the XtraBackup test suite, because there's also plugin/percona-pam-for-mysql/test/bootstrap.sh which is a verbatim copy from the XtraBackup tree and is unused in PAM plugin tests.

There's also the following WTF thing:

=== added directory 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data'
=== added file 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid'
--- Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 1970-01-01 00:00:00 +0000
+++ Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 2012-02-22 21:56:10 +0000
@@ -0,0 +1 @@
+e5f64ede-8707-4589-9c7a-fc598c0e2f6f
\ No newline at end of file

=== added symlink 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/workdir'
=== target is u'/dev/shm/qp_workdir_root_e5f64ede-8707-4589-9c7a-fc598c0e2f6f'

This has to be fixed 'upstream' before merging this into the server tree.

review: Needs Fixing

« Back to merge proposal