Merge lp:~stewart/percona-server/5.1-deprecate-innodb-fast-checksum into lp:percona-server/5.1

Proposed by Stewart Smith
Status: Merged
Approved by: Stewart Smith
Approved revision: 482
Merged at revision: 497
Proposed branch: lp:~stewart/percona-server/5.1-deprecate-innodb-fast-checksum
Merge into: lp:percona-server/5.1
Diff against target: 27 lines (+10/-0)
1 file modified
Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc (+10/-0)
To merge this branch: bzr merge lp:~stewart/percona-server/5.1-deprecate-innodb-fast-checksum
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
George Ormond Lorch III (community) g2 Approve
Review via email: mp+126608@code.launchpad.net

Description of the change

In PS5.6, we'll be removing innodb_fast_checksum, as the improved InnoDB implementation should be good enough/better. This MP adds a warning for that so that users are (less) surprised.

To post a comment you must log in.
Revision history for this message
George Ormond Lorch III (gl-az) :
review: Approve (g2)
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

fprintf should be indented as InnoDB, not MySQL code (8 space tab instead of 2 spaces).
Also in the fprintf s/WARNING/Warning, the latter is much more common and the MTR error/warning check will not miss it.

OK with these two changes.

review: Approve
483. By Stewart Smith

fix up indentation stlye for InnoDB code for innodb_fast_checksum deprecated warning

484. By Stewart Smith

s/WARNING/Warning/ in innodb_fast_checksum deprecated message

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc'
2--- Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc 2012-09-14 12:19:29 +0000
3+++ Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc 2012-10-26 04:39:21 +0000
4@@ -2540,6 +2540,14 @@
5 srv_use_checksums = (ibool) innobase_use_checksums;
6 srv_fast_checksum = (ibool) innobase_fast_checksum;
7
8+ if (innobase_fast_checksum) {
9+ fprintf(stderr,
10+ "InnoDB: Warning: innodb_fast_checksum is DEPRECATED "
11+ "and *WILL* be removed in Percona Server 5.6. Please "
12+ "consult the Percona Server 5.6 documentation for "
13+ "help in upgrading.\n");
14+ }
15+
16 srv_blocking_lru_restore = (ibool) innobase_blocking_lru_restore;
17
18 #ifdef HAVE_LARGE_PAGES
19@@ -11584,6 +11592,8 @@
20
21 static MYSQL_SYSVAR_BOOL(fast_checksum, innobase_fast_checksum,
22 PLUGIN_VAR_NOCMDARG | PLUGIN_VAR_READONLY,
23+ "DEPRECATED. #### WARNING #### : This feature is DEPRECATED and WILL "
24+ "be removed in Percona Server 5.6. "
25 "Change the algorithm of checksum for the whole of datapage to 4-bytes word based. "
26 "The original checksum is checked after the new one. It may be slow for reading page"
27 " which has orginal checksum. Overwrite the page or recreate the InnoDB database, "

Subscribers

People subscribed via source and target branches