libmemcached

Merge lp:~stewart/libmemcached/link-with-lm into lp:~tangent-org/libmemcached/trunk

  1. link-with-lm
  2. Merge into trunk
Proposed by Stewart Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp:~stewart/libmemcached/link-with-lm
Merge into: lp:~tangent-org/libmemcached/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
clients/include.am (+1/-1)
To merge this branch: bzr merge lp:~stewart/libmemcached/link-with-lm
Reviewer Review Type Date Requested Status
Monty Taylor (community) Approve
Review via email: mp+17090@code.launchpad.net

This proposal supersedes a proposal from 2010-01-10.

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote : Posted in a previous version of this proposal

otherwise got missing symbols on sqrt and the like

Revision history for this message
Monty Taylor (mordred) wrote : Posted in a previous version of this proposal

Please use $(LIBM) - not -lm.

review: Needs Fixing
Revision history for this message
Stewart Smith (stewart) wrote :

using LIBM instead of -lm as per mtaylor review

Revision history for this message
Monty Taylor (mordred) wrote :

Looks great now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clients/include.am'
2--- clients/include.am 2009-12-17 21:24:01 +0000
3+++ clients/include.am 2010-01-10 04:42:13 +0000
4@@ -69,7 +69,7 @@
5 clients/ms_stats.c \
6 clients/ms_task.c \
7 clients/ms_thread.c
8-clients_memslap_LDADD= $(LTLIBEVENT) clients/libgenexec.la $(CLIENTS_LDADDS)
9+clients_memslap_LDADD= $(LTLIBEVENT) clients/libgenexec.la $(CLIENTS_LDADDS) $(LIBM)
10
11 clients_memcapable_SOURCES= clients/memcapable.c
12 if BUILD_BYTEORDER

Subscribers

People subscribed via source and target branches

to all changes: