lp:~stewart/drizzle/table-proto-message-error-checking

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~drizzle-trunk/drizzle/development

Brian Aker: Pending requested 2010-02-10

Drizzle Developers: Pending requested 2010-02-05

Diff: 654 lines (+479/-8)

18 files modified

drizzled/error.cc (+3/-1)
drizzled/error.h (+2/-1)
drizzled/message/table_writer.cc (+69/-5)
drizzled/plugin/storage_engine.cc (+16/-1)
drizzled/table.cc (+6/-0)
plugin/blackhole/ha_blackhole.cc (+7/-0)
plugin/tableprototester/plugin.ini (+5/-0)
plugin/tableprototester/tableprototester.cc (+292/-0)
plugin/tableprototester/tableprototester.h (+58/-0)
plugin/tableprototester/tests/r/basic.result (+3/-0)
plugin/tableprototester/tests/r/drop_table.result (+2/-0)
plugin/tableprototester/tests/r/missing_engine.result (+5/-0)
plugin/tableprototester/tests/t/basic-master.opt (+1/-0)
plugin/tableprototester/tests/t/basic.test (+1/-0)
plugin/tableprototester/tests/t/drop_table-master.opt (+1/-0)
plugin/tableprototester/tests/t/drop_table.test (+2/-0)
plugin/tableprototester/tests/t/missing_engine-master.opt (+1/-0)
plugin/tableprototester/tests/t/missing_engine.test (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #516900: dropping table with corrupt table proto message results in segv	Low	Fix Released
Bug #516902: corrupt table proto does not error out correctly in open table	Low	Fix Released

Link a bug report

Related blueprints

1315. By Stewart Smith on 2010-02-08

Merged enum_field_type_to_table_message_type into table-proto-message-error-checking.

1314. By Stewart Smith on 2010-02-05

fix TableProtoTester Engine up for drizzled namespace changes.

1313. By Stewart Smith on 2010-02-05

Merged enum_field_type_to_table_message_type into table-proto-message-error-checking.

1312. By Stewart Smith on 2010-02-05

explicitly put source and header in plugin.ini for TableProtoTester engine

1311. By Stewart Smith on 2010-02-05

lint: #endif line should be "#endif /* PLUGIN_TABLEPROTOTESTER_TABLEPROTOTESTER_H */"

1310. By Stewart Smith on 2010-02-05

corrupt_table_01missing_engine test is redundant (and failed on some protobuf lib versions). TableProtoTester engine replaces it.

1309. By Stewart Smith on 2010-02-05

add missing_engine and drop_table tests for tableprototester.

1308. By Stewart Smith on 2010-02-05

add t1 test (missing engine) to TableProtoTester. Fix up proper error reporting.

1307. By Stewart Smith on 2010-02-05

initial TableProtoTester engine. We can't just use table_write as some protobuf library versions don't let us write invalid protobuf messages :(

1306. By Stewart Smith on 2010-02-05

only produce error in DropTable path if it's something interesting. also generate correct error if we have non-ER_CORRUPT_TABLE_DEFINITION error from engine in getting table definition.