lp:~stewart/drizzle/cleanups-1

Created by Stewart Smith on 2013-02-10 and last modified on 2013-02-16
Get this branch:
bzr branch lp:~stewart/drizzle/cleanups-1
Only Stewart Smith can upload to this branch. If you are Stewart Smith please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Stewart Smith
Project:
Drizzle
Status:
Merged

Recent revisions

2631. By Stewart Smith on 2013-02-16

Attempt to fix CID 980642 (#1 of 1): Uninitialized pointer read (UNINIT)
6. uninit_use: Using uninitialized value "index".

Basically try and make the code a bit more obvious that we do in fact
alloc index on first run through.

2630. By Stewart Smith on 2013-02-16

Attempt to fix CID 980643 (#1 of 1): Uninitialized pointer read (UNINIT)
6. uninit_use: Using uninitialized value "index".

Basically, false positive but we could make the code a bit more obvious
that the first run through we were going to allocate index.

2629. By Stewart Smith on 2013-02-14

Fix Coverity found bug in drizzletest.cc:
CID 973171 (#1 of 1): Out-of-bounds access (OVERRUN)
2. alloc_strlen: Allocating insufficient memory for the terminating null of the string.

This isn't exploitable, just test suite.

2628. By Stewart Smith on 2013-02-14

Fix the following Coverity warning in class COND_EQUAL

CID 973373 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member "max_members" is not initialized in this constructor nor in any functions that it calls.

2627. By Stewart Smith on 2013-02-12

data_file_name and index_file_name in ha_myisam were actually all just dead code

2626. By Stewart Smith on 2013-02-10

buffer could be not null terminated due to strncpy() call without -1 on size

2625. By Stewart Smith on 2013-02-10

fn_format codepath for MY_RESOLVE_SYMLINKS could leave string not null terminated. Turns out that was only ever set from MyISAM, which is pretty safe to not resolve symlinks now as it's temp only.

2624. By Stewart Smith on 2013-02-10

drizzletest.cc: strncpy with sizeof() rather than sizeof()-1, so string could be not null terminated

2623. By Stewart Smith on 2013-02-09

CharacterSetsTool::Generator::Generator didn't init character_set_iter

2622. By Stewart Smith on 2013-02-09

CollationsTool::Generator::Generator didn't init collation_iter

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:drizzle
This branch contains Public information 
Everyone can see this information.

Subscribers