lp:~stewart/drizzle/blob-packlength

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:drizzle/7.0 at revision 1915

Brian Aker: Needs Fixing on 2010-11-08

Diff: 616 lines (+84/-200)

6 files modified

drizzled/definition/table.cc (+0/-1)
drizzled/field/blob.cc (+48/-135)
drizzled/field/blob.h (+21/-56)
drizzled/field_conv.cc (+13/-2)
drizzled/item.cc (+0/-4)
plugin/pbxt/src/myxt_xt.cc (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #494261: Field_blob should only ever have packlength of 4

Low

Fix Released

Link a bug report

Related blueprints

1275. By Stewart Smith on 2010-11-08

change dynamic_cast in field_conv.cc back to static_cast for runtime performance

1274. By Stewart Smith on 2010-11-08

in field_conv.cc, get_copy_func should not try to cast Field_blob to Field_varstring as Field_ blob does not inherit from field_varstring. Previously this kinda worked out due to the first member of field_blob kinda making sense in this comparison. Instead, we just shortcut to that decision if we are converting from BLOB.

1273. By Stewart Smith on 2010-11-07

change cast in field_conv.cc that was producing valgrind warning to dynamic_cast to crash on invalid cast. this shows up in several tests: e.g. func_gconcat

1272. By Stewart Smith on 2010-11-07

merge trunk

1271. By Stewart Smith on 2009-12-09

remove last bits of packlength from Field_blob, leaving only support for 4 byte length for blobs (not 1, not 2 and certainly not 3).

1270. By Stewart Smith on 2009-12-09

remove Field_blob constructor that had set_packflag argument being called in Item::tmp_table_field_from_field_type(). This would cause a Field_blob to be created that used 3 bytes instead of 4 for length... potentially causing all sorts of trouble

1269. By Stewart Smith on 2009-12-09

remove Field_blob constructor that only takes packlength as argument. It's never even called

1268. By Stewart Smith on 2009-12-09

remove blob_pack_length argument to Field_blob constructor.

1267. By Brian Aker <brian@gaz> on 2010-01-12

Merge Joe

1266. By Brian Aker <brian@gaz> on 2010-01-12

Merge Stewart.