Merge lp:~stewart/drizzle/better-dbqp-alignment into lp:~drizzle-trunk/drizzle/development

Proposed by Stewart Smith on 2011-04-20
Status: Merged
Approved by: Patrick Crews on 2011-04-20
Approved revision: 2282
Merged at revision: 2286
Proposed branch: lp:~stewart/drizzle/better-dbqp-alignment
Merge into: lp:~drizzle-trunk/drizzle/development
Diff against target: 22 lines (+5/-5)
1 file modified
tests/lib/sys_mgmt/logging_management.py (+5/-5)
To merge this branch: bzr merge lp:~stewart/drizzle/better-dbqp-alignment
Reviewer Review Type Date Requested Status
Patrick Crews 2011-04-20 Approve on 2011-04-20
Drizzle Merge Team 2011-04-20 Pending
Review via email: mp+58415@code.launchpad.net

Description of the Change

aligns everything nicely for 80 column windows (like test-run.pl does). This is kinda my "start using dbpq all the time" patch :)

To post a comment you must log in.
Patrick Crews (patrick-crews) wrote :

Looks all kinds of better. Fresh set of eyes = WIN!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/lib/sys_mgmt/logging_management.py'
2--- tests/lib/sys_mgmt/logging_management.py 2011-02-07 22:20:03 +0000
3+++ tests/lib/sys_mgmt/logging_management.py 2011-04-20 01:09:29 +0000
4@@ -49,13 +49,13 @@
5 def __init__(self, variables):
6
7 self.log_file = sys.stdout
8- self.report_fmt = '{0:<55} {1} {2:>12}'
9- self.report_started = 0
10- self.thick_line = '='*80
11- self.thin_line = '-'*80
12+ self.report_fmt = '{0:<42} {1} {2:>8}'
13+ self.report_started = 0
14+ self.thick_line = '='*(80 - len("20110420-105402 "))
15+ self.thin_line = '-'*(80- len("20110420-105402 "))
16
17 def _write_message(self,level, msg):
18- self.log_file.write("%s %s: %s\n" % (time.strftime("%d %b %Y %H:%M:%S"), level, str(msg)))
19+ self.log_file.write("%s %s %s\n" % (time.strftime("%Y%m%d-%H%M%S"), level, str(msg)))
20 self.log_file.flush()
21
22 def setOutput(self,file_name):