Merge lp:~steverydz/resource-centre/update-events into lp:resource-centre

Proposed by Steve Rydz on 2018-06-05
Status: Merged
Approved by: Anthony Dillon on 2018-06-05
Approved revision: 110
Merged at revision: 110
Proposed branch: lp:~steverydz/resource-centre/update-events
Merge into: lp:resource-centre
Diff against target: 30 lines (+3/-3)
1 file modified
functions/event-posts.php (+3/-3)
To merge this branch: bzr merge lp:~steverydz/resource-centre/update-events
Reviewer Review Type Date Requested Status
Anthony Dillon 2018-06-05 Approve on 2018-06-05
Review via email: mp+347435@code.launchpad.net
To post a comment you must log in.
Anthony Dillon (ya-bo-ng) wrote :

Works, do we pull the location and venue onto post pages on blog?

review: Approve
Steve Rydz (steverydz) wrote :

That data is already in the posts. I think it would mess a lot of them up to pull it in also - bit like with the featured images

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'functions/event-posts.php'
2--- functions/event-posts.php 2018-05-29 11:30:23 +0000
3+++ functions/event-posts.php 2018-06-05 10:24:20 +0000
4@@ -128,7 +128,7 @@
5 add_meta_box( 'ept_event_venue', 'Event Venue', 'ept_event_venue', 'post', 'normal', 'default', array('id'=>'_end') );
6 add_meta_box( 'ept_event_registration', 'Event registration', 'ept_event_registration', 'post', 'normal', 'default', array('id'=>'_end') );
7 }
8-// add_action( 'admin_init', 'ep_posts_metaboxes' );
9+add_action( 'admin_init', 'ep_posts_metaboxes' );
10
11 // Metabox HTML
12
13@@ -194,7 +194,7 @@
14 // The metabox HTML
15 $event_location = get_post_meta( $post->ID, '_event_location', true );
16 echo '<label for="_event_location">Location: </label>';
17- echo '<input type="text" name="_event_location" value="' . $event_location . '" required />';
18+ echo '<input type="text" name="_event_location" value="' . $event_location . '" />';
19 }
20
21 function ept_event_venue() {
22@@ -204,7 +204,7 @@
23 // The metabox HTML
24 $event_venue = get_post_meta( $post->ID, '_event_venue', true );
25 echo '<label for="_event_venue">Venue: </label>';
26- echo '<input type="text" name="_event_venue" value="' . $event_venue . '" required />';
27+ echo '<input type="text" name="_event_venue" value="' . $event_venue . '" />';
28 }
29
30 function ept_event_registration() {

Subscribers

People subscribed via source and target branches