Merge lp:~stevenk/storm/storm-export-propertycolumn into lp:storm
Proposed by
Steve Kowalik
Status: | Needs review |
---|---|
Proposed branch: | lp:~stevenk/storm/storm-export-propertycolumn |
Merge into: | lp:storm |
Diff against target: |
12 lines (+1/-1) 1 file modified
storm/properties.py (+1/-1) |
To merge this branch: | bzr merge lp:~stevenk/storm/storm-export-propertycolumn |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Storm Developers | Pending | ||
Storm Developers | Pending | ||
Review via email: mp+71144@code.launchpad.net |
Description of the change
Due to the below error, I am exporting PropertyColumn.
** 1 import policy violations **
There were 1 imports of names not appearing in the __all__.
You should not import PropertyColumn from storm.properties:
canonical.
To post a comment you must log in.
Unmerged revisions
- 397. By Steve Kowalik
-
Export PropertyColumn in __all__.
I don't have a problem with this change, but as far as I know,
PropertyColumn is something internal to Storm and shouldn't be needed
externally. I wonder if this is something worth changing or if we
really want to keep PropertyColumn private?