Merge lp:~stevenk/storm/storm-export-propertycolumn into lp:storm

Proposed by Steve Kowalik
Status: Needs review
Proposed branch: lp:~stevenk/storm/storm-export-propertycolumn
Merge into: lp:storm
Diff against target: 12 lines (+1/-1)
1 file modified
storm/ (+1/-1)
To merge this branch: bzr merge lp:~stevenk/storm/storm-export-propertycolumn
Reviewer Review Type Date Requested Status
Storm Developers Pending
Storm Developers Pending
Review via email:

Description of the change

Due to the below error, I am exporting PropertyColumn.

** 1 import policy violations **

There were 1 imports of names not appearing in the __all__.
You should not import PropertyColumn from

To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote :

I don't have a problem with this change, but as far as I know,
PropertyColumn is something internal to Storm and shouldn't be needed
externally. I wonder if this is something worth changing or if we
really want to keep PropertyColumn private?

Unmerged revisions

397. By Steve Kowalik

Export PropertyColumn in __all__.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storm/'
2--- storm/ 2009-02-04 06:33:24 +0000
3+++ storm/ 2011-08-11 04:12:39 +0000
4@@ -36,7 +36,7 @@
5 __all__ = ["Property", "SimpleProperty",
6 "Bool", "Int", "Float", "Decimal", "RawStr", "Unicode",
7 "DateTime", "Date", "Time", "TimeDelta", "UUID", "Enum",
8- "Pickle", "List", "PropertyRegistry"]
9+ "Pickle", "List", "PropertyColumn", "PropertyRegistry"]
12 class Property(object):


People subscribed via source and target branches

to status/vote changes: