Merge lp:~stevenk/launchpad/urifield-with-leading-space into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16118 |
Proposed branch: | lp:~stevenk/launchpad/urifield-with-leading-space |
Merge into: | lp:launchpad |
Diff against target: |
121 lines (+17/-28) 4 files modified
lib/lp/app/widgets/textwidgets.py (+2/-2) lib/lp/registry/browser/productseries.py (+2/-6) lib/lp/services/fields/__init__.py (+2/-5) lib/lp/services/fields/doc/uri-field.txt (+11/-15) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/urifield-with-leading-space |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email:
|
Commit message
URIWidget is now a subclass of StrippedTextWidget, so no longer perform the stripping in URIField.
Description of the change
URIWidget is now a subclass of StrippedTextWidget, which means it will strip leading and trailing whitespace. This fixes the root cause for the OOPS, since the database validation function valid_absolute_
I've cleaned up some whitespace and pylint garbage to force this branch to net-negative, and have cleaned up a very weird copyright header that was completely lowercased.
To post a comment you must log in.