Merge lp:~stevenk/launchpad/two-part-combobuild into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14802 |
Proposed branch: | lp:~stevenk/launchpad/two-part-combobuild |
Merge into: | lp:launchpad |
Diff against target: |
72 lines (+21/-17) 3 files modified
Makefile (+5/-3) buildout-templates/bin/combo-rootdir.in (+0/-14) utilities/check-js-deps (+16/-0) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/two-part-combobuild |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+93125@code.launchpad.net |
Commit message
Split combobuild into two sections, one that is run under jsbuild.
Description of the change
Make bin/combo-rootdir safe to run anywhere, since it no longer needs convoy.
Only generate the meta file in combobuild. Split out the code that checked the meta file into a separate script, utilites/
Remove the convoy root before linking it, otherwise ln creates a js directory in build/js.
To post a comment you must log in.