Merge lp:~stevenk/launchpad/teach-rasj-about-branches into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15601 |
Proposed branch: | lp:~stevenk/launchpad/teach-rasj-about-branches |
Merge into: | lp:launchpad |
Diff against target: |
257 lines (+147/-18) 2 files modified
lib/lp/registry/model/sharingjob.py (+63/-17) lib/lp/registry/tests/test_sharingjob.py (+84/-1) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/teach-rasj-about-branches |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+114106@code.launchpad.net |
Commit message
Teach RemoveArtifactS
Description of the change
Teach RemoveArtifactS
To post a comment you must log in.
51 @property 'branch_ ids']
52 + def branch_ids(self):
53 + if not 'branch_ids' in self.metadata:
54 + return []
55 + return self.metadata[
Isn't that equivalent to "return self.metadata. get('branch_ ids', [])"?
We really need to rearchitect the tests for that job, but I guess it's OK for now. Otherwise this looks good, thanks.