Merge lp:~stevenk/launchpad/soft-oops-on-private-team-disclosure into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Steve Kowalik | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14148 | ||||
Proposed branch: | lp:~stevenk/launchpad/soft-oops-on-private-team-disclosure | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
231 lines (+98/-18) 3 files modified
lib/lp/app/browser/tales.py (+59/-18) lib/lp/app/browser/tests/test_mixed_visibility.py (+34/-0) lib/lp/services/features/flags.py (+5/-0) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/soft-oops-on-private-team-disclosure | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | code | Approve | |
Review via email: mp+79066@code.launchpad.net |
Commit message
[r=wallyworld][bug=873161] Warn (via an informational OOPS) when mixed visibility WRT private teams is encountered.
Description of the change
Warn (via an informational OOPS) when mixed visibility is encountered. This allows the Teal Squad to investigate the scope of the issue at hand, and also allows us to see which teams and pillars are implicated.
To post a comment you must log in.
Thanks for making the suggested changes on irc - rename report() and improve unit test.
Thanks also for the drive-by lint fixes.