Launchpad itself

Merge lp:~stevenk/launchpad/silence-rf-get into lp:launchpad

  1. silence-rf-get
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 13137
Proposed branch: lp:~stevenk/launchpad/silence-rf-get
Merge into: lp:launchpad
Diff against target: 24 lines (+1/-7)
1 file modified
utilities/rocketfuel-get (+1/-7)
To merge this branch: bzr merge lp:~stevenk/launchpad/silence-rf-get
Reviewer Review Type Date Requested Status
Steve Kowalik (community) code Approve
Review via email: mp+62788@code.launchpad.net

Commit message

Remove two warnings from rocketfuel-get.

Description of the change

This branch removes two warnings from rocketfuel-get. I think they can be removed for the following reasons:

1. Due to Aaron's brilliant work, updating sourcedeps is now cached, which means in the usual case, it takes a very short amount of time to trundle over all of them.
2. Since Launchpad no longer has any private branches as optional sourcedeps since the demise of shipit, we don't need to warn either.
3. Removing six lines of output is a win in and of itself.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utilities/rocketfuel-get'
2--- utilities/rocketfuel-get 2010-10-24 21:00:11 +0000
3+++ utilities/rocketfuel-get 2011-05-29 06:39:48 +0000
4@@ -1,6 +1,6 @@
5 #! /bin/bash
6 #
7-# Copyright 2009 Canonical Ltd. This software is licensed under the
8+# Copyright 2009-2011 Canonical Ltd. This software is licensed under the
9 # GNU Affero General Public License version 3 (see the file LICENSE).
10 #
11 # Update your copy of trunk and the necessary source dependencies, and make
12@@ -57,12 +57,6 @@
13
14 echo "Updating sourcecode dependencies in rocketfuel:"
15 echo ""
16-echo " NOTE: Each sourcedep may take a while; please be patient."
17-echo ""
18-echo " ALSO NOTE: You can ignore any warnings you see below about how"
19-echo " 'You have not informed bzr of your Launchpad ID ...' etc."
20-echo " See https://bugs.launchpad.net/bzr/+bug/401617 for why."
21-echo ""
22 echo " Sourcedeps: $LP_SOURCEDEPS_PATH"
23
24 run-child $LP_TRUNK_PATH/utilities/update-sourcecode $LP_SOURCEDEPS_PATH $sourcedeps_conf