Merge lp:~stevenk/launchpad/refactor-test-bugtaskfilter into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16816 |
Proposed branch: | lp:~stevenk/launchpad/refactor-test-bugtaskfilter |
Merge into: | lp:launchpad |
Diff against target: |
199 lines (+24/-74) 1 file modified
lib/lp/bugs/tests/test_bugtaskfilter.py (+24/-74) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/refactor-test-bugtaskfilter |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+192456@code.launchpad.net |
Commit message
Refactor repeated asserts in test_bugtaskfil
Description of the change
When I was investigating a test failure, I came across this file. Refactor it within an inch of its life, removing a lot of duplication into a nice and neat custom assert method.
To post a comment you must log in.