Merge lp:~stevenk/launchpad/product-limitedview-with-team-aag into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16413 |
Proposed branch: | lp:~stevenk/launchpad/product-limitedview-with-team-aag |
Merge into: | lp:launchpad |
Diff against target: |
127 lines (+35/-16) 5 files modified
lib/lp/registry/interfaces/sharingservice.py (+2/-2) lib/lp/registry/services/sharingservice.py (+14/-4) lib/lp/registry/services/tests/test_sharingservice.py (+16/-7) lib/lp/registry/tests/test_product.py (+2/-2) lib/lp/security.py (+1/-1) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/product-limitedview-with-team-aag |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+142441@code.launchpad.net |
Commit message
The LimitedView security adapter on IProduct now deals with AccessArtifactG
Description of the change
Currently, the LimitedView security adapter for IProduct checks if a user has an AccessArtifactGrant on a bug, branch or specification for the private project. This is fine, and works well, except that it doesn't work if a team the user is a member has the AAG. As such, I've rewritten ISharingService
I have done some drive-by on some asserts, using assert{True,False} rather than assertEqual(
I have more than enough LoC credit for the +19 gain.