Merge lp:~stevenk/launchpad/preload-subscriptions into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16521 |
Proposed branch: | lp:~stevenk/launchpad/preload-subscriptions |
Merge into: | lp:launchpad |
Diff against target: |
298 lines (+66/-43) 6 files modified
lib/lp/app/browser/tales.py (+14/-33) lib/lp/security.py (+2/-0) lib/lp/soyuz/browser/archivesubscription.py (+19/-7) lib/lp/soyuz/interfaces/archivesubscriber.py (+2/-1) lib/lp/soyuz/model/archive.py (+4/-0) lib/lp/soyuz/tests/test_archive_subscriptions.py (+25/-2) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/preload-subscriptions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+152073@code.launchpad.net |
Commit message
Preload archives and their owners, and pre-cache permissions for Person:
Description of the change
Preload archives and their owners, and pre-cache permissions for Person:
It turns out the bulk of the queries were trying to work out if the PPA references could be shown. Since subscribers are able to see Archive:+index I dropped the permission required to SubscriberView, and made the code make use of check_permission.
To post a comment you must log in.