Launchpad itself

Merge lp:~stevenk/launchpad/plus-queue-errors into lp:launchpad

  1. plus-queue-errors
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 16652
Proposed branch: lp:~stevenk/launchpad/plus-queue-errors
Merge into: lp:launchpad
Diff against target: 15 lines (+5/-1)
1 file modified
lib/lp/soyuz/templates/distroseries-queue.pt (+5/-1)
To merge this branch: bzr merge lp:~stevenk/launchpad/plus-queue-errors
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+166164@code.launchpad.net

Commit message

DistroSeries:+queue now displays serious errors rather than hiding the queue list.

Description of the change

DistroSeries:+queue does not display significant errors, it just hides the queue from rendering, so now it no longer hides the queue list and displays the error in a div.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/soyuz/templates/distroseries-queue.pt'
2--- lib/lp/soyuz/templates/distroseries-queue.pt 2013-05-28 05:31:13 +0000
3+++ lib/lp/soyuz/templates/distroseries-queue.pt 2013-05-29 04:20:34 +0000
4@@ -32,7 +32,11 @@
5 message view/performQueueAction;
6 error view/error|nothing">
7
8- <div class="top-portlet queue_list" tal:condition="not: error">
9+ <div class="error message" tal:condition="error">
10+ <span tal:content="error"></span>
11+ </div>
12+
13+ <div class="top-portlet queue_list">
14
15 <tal:batch define="batch view/decoratedQueueBatch|nothing">
16