Merge lp:~stevenk/launchpad/no-private-registrant-setbranch-redux into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Steve Kowalik | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 16111 | ||||
Proposed branch: | lp:~stevenk/launchpad/no-private-registrant-setbranch-redux | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
160 lines (+42/-44) 2 files modified
lib/lp/registry/browser/productseries.py (+23/-44) lib/lp/registry/browser/tests/productseries-setbranch-view.txt (+19/-0) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/no-private-registrant-setbranch-redux | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+128415@code.launchpad.net |
Commit message
Show a field error if we attempt to create a code import owned by a private team in ProductSeries:
Description of the change
While the first branch that attempted to fix this bug was fine in it's own right, it replaced one OOPS with another. This one wasn't deep in the guts of Storm, and was quite easy to ascertain meaning from. Code imports are not allowed to be owned by private teams, so we check for that and set a field error if so.
My CDO prevented me from putting up a branch that wasn't net-negative, so it contains more whitespace cleanups. I also removed a quote function that didn't seem to be called by anything.
To post a comment you must log in.
Francis reset the squad's Lines when we started Maintenance. Your count is -954 as of today. lp-dev- utils/loc- contributions --start-rev=15931 <email address hidden>
~/Work/