Launchpad itself

Merge lp:~stevenk/launchpad/lose-dsp-loc into lp:launchpad

  1. lose-dsp-loc
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 13781
Proposed branch: lp:~stevenk/launchpad/lose-dsp-loc
Merge into: lp:launchpad
Diff against target: 18 lines (+0/-8)
1 file modified
lib/lp/registry/model/distributionsourcepackage.py (+0/-8)
To merge this branch: bzr merge lp:~stevenk/launchpad/lose-dsp-loc
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+72676@code.launchpad.net

Description of the change

DistributionSourcePackage.latest_overall_component is unused (even by the test suite!), so it can die.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Lines of code should be negative. Keep up the good work.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/model/distributionsourcepackage.py'
2--- lib/lp/registry/model/distributionsourcepackage.py 2011-08-18 16:40:21 +0000
3+++ lib/lp/registry/model/distributionsourcepackage.py 2011-08-24 06:33:53 +0000
4@@ -262,14 +262,6 @@
5 "-pocket"])
6 return spph
7
8- @property
9- def latest_overall_component(self):
10- """See `IDistributionSourcePackage`."""
11- spph = self.latest_overall_publication
12- if spph:
13- return spph.component
14- return None
15-
16 def getVersion(self, version):
17 """See `IDistributionSourcePackage`."""
18 spph = SourcePackagePublishingHistory.select("""