Launchpad itself

Merge lp:~stevenk/launchpad/hide-forbidden-sprbs into lp:launchpad

  1. hide-forbidden-sprbs
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: not available
Merged at revision: 14627
Proposed branch: lp:~stevenk/launchpad/hide-forbidden-sprbs
Merge into: lp:launchpad
To merge this branch: bzr merge lp:~stevenk/launchpad/hide-forbidden-sprbs
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+87428@code.launchpad.net

Commit message

[r=jtv][bug=882834] Do not show SourcePackageRecipeBuilds that the user can't see in the SourcePackageRecipe views.

Description of the change

Do not show SourcePackageRecipeBuilds that the user can't see in the SourcePackageRecipe views.

If the archive the recipe was built into is private, then so is the SPRB. Now builds that can't be disclosed are filtered from the view and are not put into the initial values of the request-builds view.

I even managed to remember to update the copyright year for this branch.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) wrote :

Due to the branch scanner de-praming its toys every time it scans this branch, a diff is up at http://pastebin.ubuntu.com/792375/

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Exemplary. Just two points:

1. As discussed on IRC, it looks as if your original change might feed a None into check_permission. I don't know of that's bad, but at any rate you fixed it.

2. Is "this recipe has not been built yet" still the right thing to say?

Jeroen

review: Approve