Merge lp:~stevenk/launchpad/format-imports-once-more into lp:launchpad

Proposed by Steve Kowalik on 2012-08-08
Status: Merged
Approved by: William Grant on 2012-08-08
Approved revision: no longer in the source branch.
Merged at revision: 15765
Proposed branch: lp:~stevenk/launchpad/format-imports-once-more
Merge into: lp:launchpad
Diff against target: 132 lines (+14/-13)
9 files modified
lib/lp/bugs/browser/tests/test_bugview.py (+1/-1)
lib/lp/bugs/model/bugtarget.py (+4/-2)
lib/lp/bugs/model/bugtasksearch.py (+1/-1)
lib/lp/registry/browser/tests/test_product.py (+1/-1)
lib/lp/registry/model/person.py (+4/-2)
lib/lp/services/job/tests/test_celeryjob.py (+1/-1)
lib/lp/soyuz/scripts/packagecopier.py (+0/-1)
lib/lp/testing/factory.py (+1/-3)
lib/lp/testing/pages.py (+1/-1)
To merge this branch: bzr merge lp:~stevenk/launchpad/format-imports-once-more
Reviewer Review Type Date Requested Status
William Grant code 2012-08-08 Approve on 2012-08-08
Review via email: mp+118674@code.launchpad.net

Commit Message

Run format-imports lib/lp over the tree. Once more, with feeling.

Description of the Change

Run format-imports lib/lp over the tree. Once more, with feeling.

To post a comment you must log in.
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/tests/test_bugview.py'
2--- lib/lp/bugs/browser/tests/test_bugview.py 2012-07-30 05:32:01 +0000
3+++ lib/lp/bugs/browser/tests/test_bugview.py 2012-08-08 05:50:35 +0000
4@@ -17,8 +17,8 @@
5 TestCaseWithFactory,
6 )
7 from lp.testing.layers import (
8+ DatabaseFunctionalLayer,
9 LaunchpadFunctionalLayer,
10- DatabaseFunctionalLayer,
11 )
12
13
14
15=== modified file 'lib/lp/bugs/model/bugtarget.py'
16--- lib/lp/bugs/model/bugtarget.py 2012-08-07 02:58:20 +0000
17+++ lib/lp/bugs/model/bugtarget.py 2012-08-08 05:50:35 +0000
18@@ -23,9 +23,11 @@
19
20 from lp.bugs.interfaces.bugtarget import IOfficialBugTag
21 from lp.bugs.interfaces.bugtask import UNRESOLVED_BUGTASK_STATUSES
22-from lp.bugs.interfaces.bugtasksearch import BugTagsSearchCombinator
23 from lp.bugs.interfaces.bugtaskfilter import simple_weight_calculator
24-from lp.bugs.interfaces.bugtasksearch import BugTaskSearchParams
25+from lp.bugs.interfaces.bugtasksearch import (
26+ BugTagsSearchCombinator,
27+ BugTaskSearchParams,
28+ )
29 from lp.bugs.model.bugtask import BugTaskSet
30 from lp.registry.interfaces.distribution import IDistribution
31 from lp.registry.interfaces.product import IProduct
32
33=== modified file 'lib/lp/bugs/model/bugtasksearch.py'
34--- lib/lp/bugs/model/bugtasksearch.py 2012-08-07 13:50:53 +0000
35+++ lib/lp/bugs/model/bugtasksearch.py 2012-08-08 05:50:35 +0000
36@@ -91,7 +91,7 @@
37 ArrayIntersects,
38 get_where_for_reference,
39 NullCount,
40- Unnest
41+ Unnest,
42 )
43 from lp.services.propertycache import get_property_cache
44 from lp.services.searchbuilder import (
45
46=== modified file 'lib/lp/registry/browser/tests/test_product.py'
47--- lib/lp/registry/browser/tests/test_product.py 2012-07-30 19:57:10 +0000
48+++ lib/lp/registry/browser/tests/test_product.py 2012-08-08 05:50:35 +0000
49@@ -5,8 +5,8 @@
50
51 __metaclass__ = type
52
53+from lazr.restful.interfaces import IJSONRequestCache
54 import transaction
55-from lazr.restful.interfaces import IJSONRequestCache
56 from zope.component import getUtility
57 from zope.schema.vocabulary import SimpleVocabulary
58
59
60=== modified file 'lib/lp/registry/model/person.py'
61--- lib/lp/registry/model/person.py 2012-08-07 03:44:05 +0000
62+++ lib/lp/registry/model/person.py 2012-08-08 05:50:35 +0000
63@@ -135,9 +135,11 @@
64 from lp.blueprints.model.specificationworkitem import SpecificationWorkItem
65 from lp.bugs.interfaces.bugtarget import IBugTarget
66 from lp.bugs.interfaces.bugtask import IBugTaskSet
67-from lp.bugs.interfaces.bugtasksearch import BugTaskSearchParams
68+from lp.bugs.interfaces.bugtasksearch import (
69+ BugTaskSearchParams,
70+ get_person_bugtasks_search_params,
71+ )
72 from lp.bugs.model.bugtarget import HasBugsBase
73-from lp.bugs.interfaces.bugtasksearch import get_person_bugtasks_search_params
74 from lp.bugs.model.structuralsubscription import StructuralSubscription
75 from lp.code.interfaces.branchcollection import (
76 IAllBranches,
77
78=== modified file 'lib/lp/services/job/tests/test_celeryjob.py'
79--- lib/lp/services/job/tests/test_celeryjob.py 2012-08-06 20:50:51 +0000
80+++ lib/lp/services/job/tests/test_celeryjob.py 2012-08-08 05:50:35 +0000
81@@ -5,9 +5,9 @@
82 import sys
83 from time import sleep
84
85+from lazr.jobrunner.bin.clear_queues import clear_queues
86 from testtools.content import Content
87 from testtools.content_type import UTF8_TEXT
88-from lazr.jobrunner.bin.clear_queues import clear_queues
89
90 from lp.code.model.branchjob import BranchScanJob
91 from lp.scripts.helpers import TransactionFreeOperation
92
93=== modified file 'lib/lp/soyuz/scripts/packagecopier.py'
94--- lib/lp/soyuz/scripts/packagecopier.py 2012-07-30 20:14:38 +0000
95+++ lib/lp/soyuz/scripts/packagecopier.py 2012-08-08 05:50:35 +0000
96@@ -52,7 +52,6 @@
97 SoyuzScriptError,
98 )
99
100-
101 # XXX cprov 2009-06-12: this function should be incorporated in
102 # IPublishing.
103 def update_files_privacy(pub_record):
104
105=== modified file 'lib/lp/testing/factory.py'
106--- lib/lp/testing/factory.py 2012-08-01 05:47:07 +0000
107+++ lib/lp/testing/factory.py 2012-08-08 05:50:35 +0000
108@@ -247,9 +247,7 @@
109 from lp.services.temporaryblobstorage.interfaces import (
110 ITemporaryStorageManager,
111 )
112-from lp.services.temporaryblobstorage.model import (
113- TemporaryBlobStorage,
114- )
115+from lp.services.temporaryblobstorage.model import TemporaryBlobStorage
116 from lp.services.utils import AutoDecorate
117 from lp.services.webapp.dbpolicy import MasterDatabasePolicy
118 from lp.services.webapp.interfaces import (
119
120=== modified file 'lib/lp/testing/pages.py'
121--- lib/lp/testing/pages.py 2012-07-26 20:54:51 +0000
122+++ lib/lp/testing/pages.py 2012-08-08 05:50:35 +0000
123@@ -38,8 +38,8 @@
124 SimpleCookie,
125 )
126 from zope.component import getUtility
127+from zope.security.proxy import removeSecurityProxy
128 from zope.session.interfaces import ISession
129-from zope.security.proxy import removeSecurityProxy
130 from zope.testbrowser.testing import Browser
131
132 from lp.app.interfaces.launchpad import ILaunchpadCelebrities