Launchpad itself

Merge lp:~stevenk/launchpad/force-ibug-into-line into lp:launchpad

  1. force-ibug-into-line
  2. Merge into devel
Proposed by Steve Kowalik on 2012-03-08
Status: Merged
Approved by: Steve Kowalik on 2012-03-08
Approved revision: no longer in the source branch.
Merged at revision: 14925
Proposed branch: lp:~stevenk/launchpad/force-ibug-into-line
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stevenk/launchpad/force-ibug-into-line
Reviewer Review Type Date Requested Status
William Grant code 2012-03-08 Approve on 2012-03-08
Review via email: mp+96513@code.launchpad.net

Commit Message

[r=wgrant][bug=505850,949672] Force IBug into towing the line, blowing it apart into IBugPublic, IBugView and IBugEdit.

Description of the Change

Force IBug into towing the line.

This branch massively cleans up the ZCML related to IBug, and blows it apart into four separate classes: IBugPublic, IBugView, IBugEdit and IBugAdmin.

I have tried my best to keep this branch small, but the size just can't be helped due to how large the ZCML changes are, and how big IBug is.

I have also added a missing method to IBugView which was implemented in the model, listed in the ZCML, but did not appear in the old IBug.

To post a comment you must log in.
William Grant (wgrant) wrote :

171 + date_last_updated date_made_private datecreated
172 + name owner ownerID security_related tags title
173 + description who_made_private"/>

Some of these (at least date_last_updated, date_made_private, datecreated, owner, ownerID, security_related, who_made_private) should never be set directly. Hopefully it's only tests (two are mine :)) that do it, and you can remove these.

These should also all be on their own lines, like the new import policy.

174 <require
175 permission="launchpad.Admin"
176 - attributes="
177 - setHeat"
178 - set_attributes="heat_last_updated" />
179 + interface="lp.bugs.interfaces.bug.IBugAdmin"
180 + set_attributes="heat_last_updated"/>

This and IBugAdmin should be able to die. AFAICR setHeat and heat_last_updated should only be touched by Bug itself, so they don't need to be on the interface.

856 + def maybeConfirmBugtasks():
857 + """Maybe try to confirm our new bugtasks."""

Does this really need to be in IBugView?

Also, classes tend to have a blank line before the first member.

Apart from that, looks good.

review: Approve (code)

Preview Diff

Empty