Launchpad itself

Merge lp:~stevenk/launchpad/forbid-proprietary-multi-pillar into lp:launchpad

  1. forbid-proprietary-multi-pillar
  2. Merge into devel
Proposed by Steve Kowalik on 2012-04-03
Status: Merged
Approved by: Curtis Hovey on 2012-04-03
Approved revision: no longer in the source branch.
Merged at revision: 15060
Proposed branch: lp:~stevenk/launchpad/forbid-proprietary-multi-pillar
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stevenk/launchpad/forbid-proprietary-multi-pillar
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code 2012-04-03 Approve on 2012-04-03
Review via email: mp+100557@code.launchpad.net

Commit Message

Drop the multi-pillar bugs feature flag, and only have IBug.transistionToInformationType() complain when the bug is PROPRIETARY.

Description of the Change

Due to my recent refactoring, IBug.transistionToInformationType() became a lot more strict, refusing to deal with multi-pillar bugs at all and tossing an exception, whereas it used to only complain if the privacy flag was flipped (back when it was IBug.setPrivacyAndSecurityRelated()).

I have changed to only complain if the bug's information_type is PROPRIETARY, and removed the feature flag. Said feature flag was used in a fair number of places, so this diff is a little large.

I have changed the exception to explicitly mention proprietary bugs rather than private.

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

\o/ Thank you for removing the unneeded foot gun.

review: Approve (code)

Preview Diff

Empty