Launchpad itself

Merge lp:~stevenk/launchpad/fix-broken-js into lp:launchpad

  1. fix-broken-js
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 14676
Proposed branch: lp:~stevenk/launchpad/fix-broken-js
Merge into: lp:launchpad
Diff against target: 9 lines (+1/-1)
1 file modified
lib/lp/app/javascript/lp-names.js (+1/-1)
To merge this branch: bzr merge lp:~stevenk/launchpad/fix-broken-js
Reviewer Review Type Date Requested Status
Deryck Hodge (community) Approve
Review via email: mp+88526@code.launchpad.net

Commit message

Fix five broken Javascript files that were found during the combo-loader death march.

Description of the change

Fix five broken Javascript files that were found during the combo-loader death march.

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

I don't think this is correct, Steve. Sorry, man.

YUI does indeed need to be YUI(). But the change to add requires line is a good change.

Cheers,
deryck

review: Needs Fixing
Revision history for this message
Deryck Hodge (deryck) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/app/javascript/lp-names.js'
2--- lib/lp/app/javascript/lp-names.js 2011-06-21 05:37:38 +0000
3+++ lib/lp/app/javascript/lp-names.js 2012-01-13 16:52:27 +0000
4@@ -119,4 +119,4 @@
5 }
6 namespace.css_to_launchpad = css_to_launchpad;
7
8-}, "0.1", {});
9+}, "0.1", {"requires": []});