Merge lp:~stevenk/launchpad/dsd-base_source_pub-archive into lp:launchpad

Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 12596
Proposed branch: lp:~stevenk/launchpad/dsd-base_source_pub-archive
Merge into: lp:launchpad
Diff against target: 19 lines (+2/-2)
1 file modified
lib/lp/registry/model/distroseriesdifference.py (+2/-2)
To merge this branch: bzr merge lp:~stevenk/launchpad/dsd-base_source_pub-archive
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
William Grant code* Approve
Review via email: mp+53357@code.launchpad.net

Commit message

[r=lifeless,wgrant][no-qa] Look in both the parent and child *archives* when looking for the base source publication.

Description of the change

Don't limit the search for the base version source publication to the parent or child distroseries, look in both archives fully.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code*)
Revision history for this message
Robert Collins (lifeless) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/model/distroseriesdifference.py'
2--- lib/lp/registry/model/distroseriesdifference.py 2011-03-14 06:10:13 +0000
3+++ lib/lp/registry/model/distroseriesdifference.py 2011-03-15 02:53:10 +0000
4@@ -156,14 +156,14 @@
5 parent = self.derived_series.parent_series
6 result = parent.main_archive.getPublishedSources(
7 name=self.source_package_name.name,
8- version=self.base_version, distroseries=parent).first()
9+ version=self.base_version).first()
10 if result is None:
11 # If the base version isn't in the parent, it may be
12 # published in the child distroseries.
13 child = self.derived_series
14 result = child.main_archive.getPublishedSources(
15 name=self.source_package_name.name,
16- version=self.base_version, distroseries=child).first()
17+ version=self.base_version).first()
18 return result
19 return None
20