Merge lp:~stevenk/launchpad/delete-milestone-all-bugs into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 16014 | ||||
Proposed branch: | lp:~stevenk/launchpad/delete-milestone-all-bugs | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
130 lines (+43/-11) 4 files modified
lib/lp/bugs/interfaces/bugtasksearch.py (+2/-1) lib/lp/bugs/model/bugtasksearch.py (+5/-4) lib/lp/registry/browser/__init__.py (+12/-6) lib/lp/registry/browser/tests/test_milestone.py (+24/-0) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/delete-milestone-all-bugs | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+125924@code.launchpad.net |
Commit message
Milestone:+delete made the assumption that whoever was deleting the milestone had the permissions to see every bugtask that referenced that milestone -- make certain to get all bugtasks and drop the milestone so it can be deleted safely.
Description of the change
Milestone:+delete made the assumption that whoever was deleting the milestone had the permissions to see every bugtask that referenced that milestone. I have extended BugTaskSearch to ignore privacy for this one call site and made use of rSP to make certain that we can unreference all bugtasks before we delete the milestone.
To post a comment you must log in.
Thank you.