Merge lp:~stevenk/launchpad/deal-with-changeinformationtype into lp:launchpad
Proposed by
Steve Kowalik
| Status: | Merged |
|---|---|
| Approved by: | Steve Kowalik |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 15348 |
| Proposed branch: | lp:~stevenk/launchpad/deal-with-changeinformationtype |
| Merge into: | lp:launchpad |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~stevenk/launchpad/deal-with-changeinformationtype |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ian Booth (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Properly hide the "Keep branch confidential" checkbox if the branch is stacked on a private branch.
Description of the change
When information_type handling for Branch was added, some of the rules changed in terms when a branch can change privacy. Since branches stacked on private branches are no longer allowed to change their privacy, we should detect that case properly instead of pretending to allow it and then de-praming our toys in the form of an OOPS.
To post a comment you must log in.
Love the "de-praming our toys" bit