Merge lp:~stevenk/launchpad/db-bugsubscriptionfilter-itype into lp:launchpad/db-devel

Proposed by Steve Kowalik on 2012-07-27
Status: Merged
Approved by: Steve Kowalik on 2012-08-01
Approved revision: no longer in the source branch.
Merged at revision: 11802
Proposed branch: lp:~stevenk/launchpad/db-bugsubscriptionfilter-itype
Merge into: lp:launchpad/db-devel
Diff against target: 99 lines (+21/-0)
2 files modified
database/schema/patch-2209-26-3.sql (+11/-0)
database/schema/security.cfg (+10/-0)
To merge this branch: bzr merge lp:~stevenk/launchpad/db-bugsubscriptionfilter-itype
Reviewer Review Type Date Requested Status
Stuart Bishop db 2012-07-27 Approve on 2012-07-31
Robert Collins db 2012-07-27 Pending
Review via email: mp+117003@code.launchpad.net

Commit Message

Add a new table that will allow people to structurally subscribe to all bugs for a product with a given information_type.

Description of the Change

Add a new table that will allow people to structurally subscribe to all bugs for a product with a given information_type, now that they will soon work for non-public bugs.

To post a comment you must log in.
Stuart Bishop (stub) wrote :

It looks like (filter, information_type) should be unique. This also allows you to drop the id column and make (filter, information_type) the primary key.

Stuart Bishop (stub) :
review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2209-26-3.sql'
2--- database/schema/patch-2209-26-3.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2209-26-3.sql 2012-07-31 06:25:23 +0000
4@@ -0,0 +1,11 @@
5+-- Copyright 2012 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+
8+SET client_min_messages=ERROR;
9+
10+CREATE TABLE BugSubscriptionFilterInformationType (
11+ filter integer REFERENCES BugSubscriptionFilter(id) NOT NULL,
12+ information_type integer NOT NULL,
13+ CONSTRAINT bugsubscriptioninformationtype_pkey PRIMARY KEY (filter, information_type));
14+
15+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 26, 3);
16
17=== modified file 'database/schema/security.cfg'
18--- database/schema/security.cfg 2012-07-25 18:56:53 +0000
19+++ database/schema/security.cfg 2012-07-31 06:25:23 +0000
20@@ -588,6 +588,7 @@
21 public.bugnotificationrecipient = SELECT, INSERT
22 public.bugsubscription = SELECT
23 public.bugsubscriptionfilter = SELECT
24+public.bugsubscriptionfilterinformationtype = SELECT
25 public.bugsubscriptionfilterimportance = SELECT
26 public.bugsubscriptionfilterstatus = SELECT
27 public.bugsubscriptionfiltertag = SELECT
28@@ -654,6 +655,7 @@
29 public.bugnotificationrecipient = SELECT, INSERT
30 public.bugsubscription = SELECT
31 public.bugsubscriptionfilter = SELECT
32+public.bugsubscriptionfilterinformationtype = SELECT
33 public.bugsubscriptionfilterimportance = SELECT
34 public.bugsubscriptionfilterstatus = SELECT
35 public.bugsubscriptionfiltertag = SELECT
36@@ -873,6 +875,7 @@
37 public.bugnotificationrecipient = SELECT, INSERT
38 public.bugsubscription = SELECT
39 public.bugsubscriptionfilter = SELECT
40+public.bugsubscriptionfilterinformationtype = SELECT
41 public.bugsubscriptionfilterimportance = SELECT
42 public.bugsubscriptionfilterstatus = SELECT
43 public.bugsubscriptionfiltertag = SELECT
44@@ -1157,6 +1160,7 @@
45 public.bugnomination = SELECT, INSERT, UPDATE, DELETE
46 public.bugsubscription = SELECT, INSERT, UPDATE, DELETE
47 public.bugsubscriptionfilter = SELECT, INSERT, UPDATE, DELETE
48+public.bugsubscriptionfilterinformationtype = SELECT, INSERT, UPDATE, DELETE
49 public.bugsubscriptionfilterimportance = SELECT, INSERT, UPDATE, DELETE
50 public.bugsubscriptionfiltermute = SELECT, INSERT, UPDATE, DELETE
51 public.bugsubscriptionfilterstatus = SELECT, INSERT, UPDATE, DELETE
52@@ -1313,6 +1317,7 @@
53 public.bugnotificationrecipient = SELECT, INSERT
54 public.bugsubscription = SELECT
55 public.bugsubscriptionfilter = SELECT
56+public.bugsubscriptionfilterinformationtype = SELECT
57 public.bugsubscriptionfilterimportance = SELECT
58 public.bugsubscriptionfilterstatus = SELECT
59 public.bugsubscriptionfiltertag = SELECT
60@@ -1421,6 +1426,7 @@
61 public.bugnotificationrecipient = SELECT, INSERT
62 public.bugsubscription = SELECT
63 public.bugsubscriptionfilter = SELECT
64+public.bugsubscriptionfilterinformationtype = SELECT
65 public.bugsubscriptionfilterimportance = SELECT
66 public.bugsubscriptionfilterstatus = SELECT
67 public.bugsubscriptionfiltertag = SELECT
68@@ -1531,6 +1537,7 @@
69 public.bugnotificationrecipient = SELECT, INSERT, UPDATE
70 public.bugsubscription = SELECT, INSERT
71 public.bugsubscriptionfilter = SELECT, INSERT
72+public.bugsubscriptionfilterinformationtype = SELECT, INSERT
73 public.bugsubscriptionfilterimportance = SELECT, INSERT
74 public.bugsubscriptionfiltermute = SELECT, INSERT
75 public.bugsubscriptionfilterstatus = SELECT, INSERT
76@@ -1720,6 +1727,7 @@
77 public.bugnotificationrecipient = SELECT, INSERT
78 public.bugsubscription = SELECT, INSERT, UPDATE, DELETE
79 public.bugsubscriptionfilter = SELECT, INSERT, UPDATE, DELETE
80+public.bugsubscriptionfilterinformationtype = SELECT, INSERT, UPDATE, DELETE
81 public.bugsubscriptionfilterimportance = SELECT, INSERT, UPDATE, DELETE
82 public.bugsubscriptionfilterstatus = SELECT, INSERT, UPDATE, DELETE
83 public.bugsubscriptionfiltertag = SELECT, INSERT, UPDATE, DELETE
84@@ -2016,6 +2024,7 @@
85 public.bugmessage = SELECT, INSERT
86 public.bugsubscription = SELECT, INSERT
87 public.bugsubscriptionfilter = SELECT, INSERT
88+public.bugsubscriptionfilterinformationtype = SELECT, INSERT
89 public.bugsubscriptionfilterimportance = SELECT, INSERT
90 public.bugsubscriptionfilterstatus = SELECT, INSERT
91 public.bugsubscriptionfiltertag = SELECT, INSERT
92@@ -2215,6 +2224,7 @@
93 public.bugnotificationrecipientarchive = SELECT
94 public.bugsubscription = SELECT
95 public.bugsubscriptionfilter = SELECT
96+public.bugsubscriptionfilterinformationtype = SELECT
97 public.bugsubscriptionfilterimportance = SELECT
98 public.bugsubscriptionfilterstatus = SELECT
99 public.bugsubscriptionfiltertag = SELECT

Subscribers

People subscribed via source and target branches

to status/vote changes: