Merge lp:~stevenk/launchpad/bugtask-activity-preload into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Steve Kowalik | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15928 | ||||
Proposed branch: | lp:~stevenk/launchpad/bugtask-activity-preload | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
138 lines (+48/-2) 4 files modified
lib/lp/bugs/browser/bug.py (+8/-0) lib/lp/bugs/browser/tests/test_bug_views.py (+34/-0) lib/lp/bugs/interfaces/bugactivity.py (+5/-1) lib/lp/bugs/templates/bug-activity.pt (+1/-1) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/bugtask-activity-preload | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+123484@code.launchpad.net |
Commit message
Pre-load persons for Bug:+activity.
Description of the change
Change Bug:+activity to bulk load the people from ValidPersonCache. With 10 BugActivity rows, the query count drops from 13 to 5, and with 50 rows the query count drops from 53 to 5. This also required adding a personID attribute onto IBugActivity.
To post a comment you must log in.
Look good.