Merge lp:~stevenk/launchpad/bugs-use-information_type-redux into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15009 |
Proposed branch: | lp:~stevenk/launchpad/bugs-use-information_type-redux |
Merge into: | lp:launchpad |
Diff against target: |
399 lines (+96/-44) 9 files modified
lib/lp/bugs/adapters/bug.py (+16/-1) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+1/-5) lib/lp/bugs/mail/tests/test_handler.py (+2/-2) lib/lp/bugs/model/bug.py (+32/-23) lib/lp/bugs/model/tests/test_bug.py (+19/-0) lib/lp/bugs/tests/test_bug_mirror_access_triggers.py (+3/-3) lib/lp/registry/enums.py (+11/-0) lib/lp/registry/model/person.py (+2/-2) lib/lp/services/feeds/stories/xx-security.txt (+10/-8) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/bugs-use-information_type-redux |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+99236@code.launchpad.net |
Commit message
Resurrect use of IBug.informatio
Description of the change
Resurrect the rollback of using IBug.informatio
Rename IBug.{private,
Fixed some tests that assumed that IBug.{private,
I cleaned up a small amount of lint.
Further to those changes, I have created a new method, convert_
251 + def test_informatio n_type_ does_not_ leak(self) : makeProduct( )
252 + product = self.factory.
Not entirely descriptive :)
Also:
10:52:57 < wgrant> StevenK: I think I mentioned this in the last review, but from the diff it looks like bug.private writes were previously permitted by the security policy, but I don't see any ZCML changes in this brnach to prevent that. security_ related aren't in the ZCML, so I'm not sure how to tell it "forbid anyone setting these"
10:58:14 < StevenK> wgrant: wgrant: private/
11:00:04 < wgrant> StevenK: Indeed. I wonder if the removeSecurityProxy is really required, then